Date:   Fri, 10 Dec 2021 13:16:55 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     pmladek@suse.com, valentin.schneider@arm.com, peterz@infradead.org,
        keescook@chromium.org, robdclark@chromium.org,
        samitolvanen@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kthread: potential dereference of null pointer
Message-Id: <20211210131655.2eeb8f866382c324b605a6ce@linux-foundation.org>
In-Reply-To: <20211209064314.2074885-1-jiasheng@iscas.ac.cn>
References: <20211209064314.2074885-1-jiasheng@iscas.ac.cn>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu,  9 Dec 2021 14:43:14 +0800 Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote:

> The return value of kzalloc() needs to be checked.
> To avoid use of null pointer in case of the failure of alloc.
> 
> ...
>
> --- a/kernel/kthread.c
> +++ b/kernel/kthread.c
> @@ -101,6 +101,8 @@ void set_kthread_struct(struct task_struct *p)
>  		return;
>  
>  	kthread = kzalloc(sizeof(*kthread), GFP_KERNEL);
> +	if (!kthread)
> +		return;
>  	/*
>  	 * We abuse ->set_child_tid to avoid the new member and because it
>  	 * can't be wrongly copied by copy_process(). We also rely on fact

No, we shouldn't simply leave ->set_child_tid uninitialized if kmalloc
failed.

set_ktread_struct() appears to be designed so that callers must check
that to_kthread() returns non-zero after having called
set_kthread_struct().

Which is a quite weird interface, but I'm not seeing any bugs here.  If
kthread() sees to_kthread()==NULL then this kthread won't be created
and all the other unchecked calls to to_kthread() will never execute,
because this kthread doesn't exist.

The exception is in init_idle(), but that's __init code, executed at
boot time when we assume that allocations will always succeed.