From:   Thomas Gleixner <tglx@linutronix.de>
To:     "Nakajima, Jun" <jun.nakajima@intel.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "Liu, Jing2" <jing2.liu@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Jing Liu <jing2.liu@linux.intel.com>,
        "seanjc@google.com" <seanjc@google.com>,
        "Cooper, Andrew" <andrew.cooper3@citrix.com>,
        "Bae, Chang Seok" <chang.seok.bae@intel.com>
Subject: Re: Rewording of Setting IA32_XFD[18] (Re: Thoughts of AMX KVM
 support based on latest kernel)
In-Reply-To: <9F8F8297-E70F-427C-BEDA-9FAB86877DBD@intel.com>
Date:   Fri, 10 Dec 2021 22:53:37 +0100
Message-ID: <87bl1oxh26.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jun,

On Wed, Dec 08 2021 at 00:50, Jun Nakajima wrote:
>> On Nov 19, 2021, at 7:41 AM, Nakajima, Jun <jun.nakajima@intel.com> wrot=
e:
>> I=E2=80=99ll work with the H/W team on those (i.e. rewording and the com=
ponent 17 issue).
>>=20
>
> The following is a possible documentation update that may convey the
> rewording you requested.  Does this (the last sentence, =E2=80=9CIn addit=
ion,
> =E2=80=9C) work for you?
>
> 3.3 RECOMMENDATIONS FOR SYSTEM SOFTWARE
>
> System software may disable use of Intel AMX by clearing XCR0[18:17],
> by clearing CR4.OSXSAVE, or by setting IA32_XFD[18]. System software
> should initialize AMX state (e.g., by executing TILERELEASE) when
> doing so because maintaining AMX state in a non-initialized state may
> have negative power and performance implications. In addition,
> software should not rely on the state of the tile data after setting
> IA32_XFD[18]; software should always reload or reinitialize the tile
> data after clearing IA32_XFD[18].

looks good to me.

Thanks,

        tglx