MIME-Version: 1.0
References: <20211115085630.1756817-1-elver@google.com> <YZJw69RdPES7gHBM@smile.fi.intel.com>
 <CANpmjNMcxQ1YrvsbO-+=5vmW6rwhChjgB20FUMKvHQ9HXNwcAg@mail.gmail.com>
 <YZJ01V8fZBlWz4VW@smile.fi.intel.com> <20211210183520.5cb1c4d4@gandalf.local.home>
In-Reply-To: <20211210183520.5cb1c4d4@gandalf.local.home>
From:   Marco Elver <elver@google.com>
Date:   Sat, 11 Dec 2021 00:38:22 +0100
Message-ID: <CANpmjNMda2Gu48wOTQAb0pGHK7-EFPngbr-0r2RnJmM7J9mcMw@mail.gmail.com>
Subject: Re: [PATCH] panic: use error_report_end tracepoint on warnings
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Potapenko <glider@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Petr Mladek <pmladek@suse.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Wei Liu <wei.liu@kernel.org>, Mike Rapoport <rppt@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        John Ogness <john.ogness@linutronix.de>,
        linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
        Alexander Popov <alex.popov@linux.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 11 Dec 2021 at 00:35, Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Mon, 15 Nov 2021 16:55:17 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > > > >       ERROR_DETECTOR_KFENCE,
> > > > > -     ERROR_DETECTOR_KASAN
> > > > > +     ERROR_DETECTOR_KASAN,
> > > > > +     ERROR_DETECTOR_WARN
> > > >
> > > > ...which exactly shows my point (given many times somewhere else) why comma
> > > > is good to have when we are not sure the item is a terminator one in the enum
> > > > or array of elements.
> > >
> > > So you want me to add a comma?
> >
> > Yes. And you see exactly why I'm asking for that.
> >
> > > (I'm not participating in bikeshedding here, just tell me what to do.)
> >
> > Done!
>
> Is there going to be another patch set? Or did I miss it?

Andrew was kind enough to fix it up for me. :-)
It's already in -mm:
  https://www.spinics.net/lists/mm-commits/msg161488.html
  https://www.spinics.net/lists/mm-commits/msg161487.html

Thanks,
-- Marco