Message-ID: <7d113a50-5efd-d45e-04b9-a29023092518@oracle.com>
Date:   Fri, 10 Dec 2021 19:47:06 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/gntdev: fix unmap notification order
Content-Language: en-US
To:     Oleksandr Andrushchenko <andr2000@gmail.com>,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc:     jgross@suse.com, sstabellini@kernel.org,
        Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
        stable@vger.kernel.org
References: <20211210092817.580718-1-andr2000@gmail.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211210092817.580718-1-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFMyNHZyc1RQQktFbStsYmxxbWQwRmRTUlhmU1JKbVl1THNraWVWUWdKVFFj?=
 =?utf-8?B?b0RxOGcrSHNkeVBXSjZpeVZSbzR6a1NjODkxb3UwRGErUmdWcmRNMy9GaGNM?=
 =?utf-8?B?alBZckNpNW9EQW9UZ0dlME85cTFaOHYzMFpDTTRpRWwycFNyQTFoUE9KT09h?=
 =?utf-8?B?Z0Q0a0tZeVZUMVFua1ZWRXc0U1JYRUNJdyttZkRDOFdKY012dks3bm45NFFH?=
 =?utf-8?B?bHlZV0E5UGJ4TXpQSzlKODE1NzRNMWZ0NDUwZGprcUV2NTU1MlZTajR2Q0dP?=
 =?utf-8?B?UzZLOXN3WlZ3eU1YSkdkb2xZMGpNb1FGWWZESXJTbmRSME9Xb29LZDhPSWEv?=
 =?utf-8?B?WTN3VXFrUkxnTXk0RDc3bXdkbHA4MDQzU1JmZGQvcThYY0ZsbGJUUmFXTmtw?=
 =?utf-8?B?RlpJYTh1cGlIMHowZTdpRDVEWVExRWJxMW5QNjd5YTNuYkppSG9TeHNNTVNE?=
 =?utf-8?B?TTdsbDRUSk9zSy9ERGl5MUw1QmJsa0pZZFZ4QzlPSG54dkRYNkxsc0hpRUxi?=
 =?utf-8?B?bUVpQnBsWTA2SG93WmUxVUFYWUJnTUNlUzlSa0kxZE83U2tLN2JHbUxUMHgx?=
 =?utf-8?B?RW1EdmpjRTBnZjlUWnhBL1c0VjFVekRCQzY4ZDdtcTJBNHFSd1ZiZ3VpMUIx?=
 =?utf-8?B?NTA1NWdBeUpQY3F4TEQ2aHdhRVJJck14TjR5NHcwUWFvVk9UY3ZSQlRSVE5U?=
 =?utf-8?B?Ky80TUF0cmJMWng2bTY3dXk1TlFJUTNRcHJMdk52bHZJODRyVlpJZEIvWHFF?=
 =?utf-8?B?dCtwbWFweDR6Wi9DMHRwckNYNnJzelNrSmhDOU5ETjVPOUx3dkZNSVd6QXps?=
 =?utf-8?B?Rzhzakc0OW5YYU5vZEl6V2NjcHZiNkxrYkRJTnl5Q0pTTS85ZGFBTk90MnZX?=
 =?utf-8?B?UU9mTnpXWUNZckRId0NKdkNyMUU5MnArNmhNN0xrWGZNWkFtWTZXL0ozTGpJ?=
 =?utf-8?B?R0hMQzlOOEFzbDBKN3pSOUJSbDhlNEtidHU1M1JKZHpRdTgvVFJRWjVlcDQ1?=
 =?utf-8?B?c2Jqc3ZHb2UyWnVrVWxmM3lCMmZIdDNPY1ZqNmZNLy9Pekk0emlGQWpNQkR6?=
 =?utf-8?B?bmQ5WHZFK0Fwd3hscncwamdDMXlmNnQydHhkQWNKRm82eW1xRnovQUROTVN1?=
 =?utf-8?B?eVdPK3dnWXpoSlhMSE1pRjlFWkZVRVQzN1M0blUvU1o3c0hiZDFoZzZFbit0?=
 =?utf-8?B?TTJtSUY4Y3F4aUtHQ3NtVDZVT2hSQUdXdy9STUpHZE5nYWZwMjJqRWFHRFJK?=
 =?utf-8?B?eGZCdnE2SERrVE1NNmRvdkVENWJmY3pCN2x3VVJhMitMYnlLNUhxdHd3bkp0?=
 =?utf-8?B?WUNWR3VtK2VxakhFOHRBK2xjWS9PdkFDVzMxS2ljanQzQk4wNDZ3c2xGc0xE?=
 =?utf-8?B?allETVdQWU9rbHk3NVl1K2NRVk1PeEJ4WmYyQ0RORWl5YVFac1A2a0Z0bWpy?=
 =?utf-8?B?WHBwNHhWZEZ0dHZ1SjJXWmI1RThIWGZBTUdjU0s5bTlNbGVZbXNnL3lSbWVu?=
 =?utf-8?B?YlB5L09keDQrVXF2Y0FuZXdmejZIOFdobk9iVTFJekw2YmdkUTBuUVdDUFI2?=
 =?utf-8?B?QjkwS3VMa1hzNVcwbzR5Z2Q5WGFTTWpMS3Jaem00Q2FiRElWS1hZNm4vNE5u?=
 =?utf-8?B?bTlzeFBIYmRmQmJ2YmZMSEg5Y2J3aHlqVTBxbUw0T1lMQVNGN2x3Y005SFhi?=
 =?utf-8?B?RjhVKzUwUFc0SUdMa0wyVTdjUCt2RmFyZWw1VXlLbTJZRXZXcXlFaDk1ZFpH?=
 =?utf-8?B?T3pkdGY1UFUwbG4wSlEwZlZ1Zlp3QVN4U2VheFZyUHhyVmpsOE9aZ2IvM05Y?=
 =?utf-8?B?Nml2ME41eEdoeitqQmxWUGxVSnVQek0vcUpVY0swa2YvZGU0QUtoeTJZSldL?=
 =?utf-8?B?eWxYVzVMUUVQczlrY0d6K3NuTmpUMExTOHBYSEtGTU83d1A3U0xIZ1hYZldp?=
 =?utf-8?B?VndickdCZ3p0b04wSk5kTHQrLzNPUVMrRmtBQ0FFdEV4YWd5TE5HOFc1SUZJ?=
 =?utf-8?B?eDhJS3VUejYrVGtCbXZvTlFkU3lMRmJEQ0U4T0F2WTYzVkpjRjl2bi8vQ20z?=
 =?utf-8?B?RjVwejVIYk45UG1zejRnWXJnblFQNlF4WGpsVkFRWTIveGNnRENXU1FDS2E2?=
 =?utf-8?B?K0t0SjJFZHZXVHpVSDQ5ZHJEdy94bkJnVnZzSlNWcW1xSlJkRDFPR0JiNlNs?=
 =?utf-8?B?aVdoTWZOZHpBQS9EMnYzM1Z4ZEoydUxySGRIcW1uWkEvQTRXdUVjeHhZTHJz?=
 =?utf-8?Q?ZYQr9kHO+AF7Exd75l8UPi4unPKVEUp6PN6X8nynAM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d8dffe1f-896d-4998-8b1f-08d9bc3fc4d6
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2021 00:47:12.2435
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yl9OsHMNy00jvK5+I3EsJWRnA0tmv9LLN1bEseKohsbsmZb7nCGwZZOnvhpj+Az33HuaXGgfEq5ONbiH6jcxxF3e4HLon6V7BoVKKz30xtQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2785
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10194 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 phishscore=0
 malwarescore=0 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112110002
X-Proofpoint-GUID: TWGs4aqLsOq0i3R41SlAq0tg-krBIW4K
X-Proofpoint-ORIG-GUID: TWGs4aqLsOq0i3R41SlAq0tg-krBIW4K
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/10/21 4:28 AM, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> While working with Xen's libxenvchan library I have faced an issue with
> unmap notifications sent in wrong order if both UNMAP_NOTIFY_SEND_EVENT
> and UNMAP_NOTIFY_CLEAR_BYTE were requested: first we send an event channel
> notification and then clear the notification byte which renders in the below
> inconsistency (cli_live is the byte which was requested to be cleared on unmap):
>
> [  444.514243] gntdev_put_map UNMAP_NOTIFY_SEND_EVENT map->notify.event 6
> libxenvchan_is_open cli_live 1
> [  444.515239] __unmap_grant_pages UNMAP_NOTIFY_CLEAR_BYTE at 14
>
> Thus it is not possible to reliably implement the checks like
> - wait for the notification (UNMAP_NOTIFY_SEND_EVENT)
> - check the variable (UNMAP_NOTIFY_CLEAR_BYTE)
> because it is possible that the variable gets checked before it is cleared
> by the kernel.
>
> To fix that we need to re-order the notifications, so the variable is first
> gets cleared and then the event channel notification is sent.
> With this fix I can see the correct order of execution:
>
> [   54.522611] __unmap_grant_pages UNMAP_NOTIFY_CLEAR_BYTE at 14
> [   54.537966] gntdev_put_map UNMAP_NOTIFY_SEND_EVENT map->notify.event 6
> libxenvchan_is_open cli_live 0
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>