Message-ID: <f04bc4ba7ed1d8a1dc62b89d4fc0de6e794126f2.camel@kernel.org>
Subject: Re: [PATCH 08/25] x86/sgx: Make SGX IPI callback available
 internally
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Reinette Chatre <reinette.chatre@intel.com>
Cc:     dave.hansen@linux.intel.com, tglx@linutronix.de, bp@alien8.de,
        luto@kernel.org, mingo@redhat.com, linux-sgx@vger.kernel.org,
        x86@kernel.org, seanjc@google.com, kai.huang@intel.com,
        cathy.zhang@intel.com, cedric.xing@intel.com,
        haitao.huang@intel.com, mark.shanahan@intel.com, hpa@zytor.com,
        linux-kernel@vger.kernel.org
Date:   Sat, 11 Dec 2021 09:53:17 +0200
In-Reply-To: <bda9f351-6820-5978-44c5-0ca48fe7f31a@intel.com>
References: <cover.1638381245.git.reinette.chatre@intel.com>
         <d4c030fd6bc8d5a618204abaea4b97489f137cc9.1638381245.git.reinette.chatre@intel.com>
         <YavzKF3LooOmj3Un@iki.fi> <bda9f351-6820-5978-44c5-0ca48fe7f31a@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.42.2 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2021-12-06 at 13:36 -0800, Reinette Chatre wrote:
> Hi Jarkko,
>=20
> On 12/4/2021 3:00 PM, Jarkko Sakkinen wrote:
> > On Wed, Dec 01, 2021 at 11:23:06AM -0800, Reinette Chatre wrote:
> > > The ETRACK instruction followed by an IPI to all CPUs within an encla=
ve
> > > is a common pattern with more frequent use in support of SGX2.
> > >=20
> > > Make the (empty) IPI callback function available internally in
> > > preparation for more usages.
> >=20
> > Please, just describe the usages that this is needed for so that
> > there is zero guesswork required.
>=20
> The reader is not required to guess. The first paragraph states that=20
> SGX2 also uses the ETRACK flow that relies on this function. What if I=
=20
> replace "for more usages" by "for usage by SGX2"?

I think that'd be good enough.

/Jarkko