From:   Francesco Dolcini <francesco.dolcini@toradex.com>
To:     philippe.schenker@toradex.com, andrew@lunn.ch,
        qiangqing.zhang@nxp.com
Cc:     davem@davemloft.net, festevam@gmail.com, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
        netdev@vger.kernel.org,
        Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: [PATCH net-next] net: phy: perform a PHY reset on resume
Date:   Sat, 11 Dec 2021 14:01:46 +0100
Message-Id: <20211211130146.357794-1-francesco.dolcini@toradex.com>
In-Reply-To: <7a4830b495e5e819a2b2b39dd01785aa3eba4ce7.camel@toradex.com>
References: <7a4830b495e5e819a2b2b39dd01785aa3eba4ce7.camel@toradex.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Gl4eKX+iwgB1USkePlCf2va32P2MQ4tGHC8+11+XmojZyJ4Rbt69rphWr0i7?=
 =?us-ascii?Q?VMQtv1oze1MddGAhqQZFW8llYsSER2lqbDResyjxP9jaaqP3ORgjDVf8FzoD?=
 =?us-ascii?Q?TzsIXxUMEOPDWQdANMctYjJC0kJodhp/RZ4cb6yQw41fPm/Q+mKhXJo5DfLt?=
 =?us-ascii?Q?9EVlQ6tDbApX2j36FjfEdtoTlwlHs9mCBlb+t17fBm6cROtz8gkQBqH00cwv?=
 =?us-ascii?Q?anfg1KRoCIaY4UsYKuEse4GHqATSEnoXKDDIa6tQAykMl5McfpDDJCqr6R7J?=
 =?us-ascii?Q?sbxza8sa7L/c14HmQKE3d2QIQLXC8Xu9oFuYmBtUQQQ4+nkFntT9KP1Kr5Km?=
 =?us-ascii?Q?SDLPb1u/+VrbUJ8J5HSUFRYra1puLppXU21c0ZLOwZtQfP5Nn9QUxZw3Dm6y?=
 =?us-ascii?Q?6x5qem5MtlD+XGD19vKWfQimOaEpYTvzwjBiUT8+Y8EOi96rPWL3XwaUMZ+H?=
 =?us-ascii?Q?Fw62ICgK9WS1S8uXMmtSBaH1V/oV0zlfuh7YZrYUSq1xZZ7ZpXMBpcRy3PAi?=
 =?us-ascii?Q?k5z+tyA0fFbMKSoUSJWxEQjFjLE+5z4+4MRD9UPzGNoGhCeH7q/yKBRWZSqA?=
 =?us-ascii?Q?u9yr5Fc28v87likccHIL1H+1F96ygiGcfcR470eVz94OEOzJ5/1tAQBb08Be?=
 =?us-ascii?Q?5JMUR7pIZO148SL8s7aLMRzi49cLuI0HS0ptxkE6yRMeVq4PUuchv30M4jlo?=
 =?us-ascii?Q?3g4EQOpSrUkKYo4jssP8Gzs9I7LmlZ5WCqKR2n+eT/olXgmQCC6PtpEs2IID?=
 =?us-ascii?Q?cl8y+C6gNQZf0Htf7vOigQ8IDMqxe4UQZZZWmEfGvKHOhh9L00TLFpG75uK1?=
 =?us-ascii?Q?DJy2ATviDWhqvzlXr3fcT/6+txoXl56gXKt0AU6Q4q4re710y5vYlGY0olbG?=
 =?us-ascii?Q?/5m2JjMMdbAn32oNCZway/eqYsz5KI76JNnTEV8ZDhihT0hmrJruRSpV+2tQ?=
 =?us-ascii?Q?ayXBRUvvH/PHEq1w5+maHm/R/AUbLU55i5f8K+MG8xVtXmCJDq/imEtkfMNY?=
 =?us-ascii?Q?eN5ZofPnhpyIphogtcvLx4q0IhVYub7Xpxm9PtOXB3658cFTXAb1EFoYiEZv?=
 =?us-ascii?Q?E38s0dIM6ab1K3mBsGvW+iWZh3mpiEHkaCGyrawG0kQGQmdwfM0zODXdaelc?=
 =?us-ascii?Q?PS9R28V5d4rIHZ/tZ56m2FoZrktZ7IOgCbR4b0ETa0RAJ2z+0lApEEjFjfkZ?=
 =?us-ascii?Q?uaGfOnJlABR8aweztiKDheTYTI5GNLMicSlq+xp0fuzXAL8IDb3pxH7DLoxi?=
 =?us-ascii?Q?1R66QbdmweQd/iBA3XPlfM18Wca+PaAbx2vK3PrlN81amdBb7bOLpnbNgZ2j?=
 =?us-ascii?Q?lHBtoT8wzQHudjejn5Ymw/KZttZFQktfr6veGpwGpqeAMcxlswEupR0HuYd0?=
 =?us-ascii?Q?aLCzNBa9cxKaJaY44E/fjuBGsjIi8BwdX8NWsK7+eHM4TYt2e6qRe9MpSiTm?=
 =?us-ascii?Q?kGUEIU76jb0yr+wlbMGTD8ZQgaf0NFUVV6eyrc2fzjIOmNIaBaItojKP16IW?=
 =?us-ascii?Q?u4+MQgZZ1MtQcjZXpM5f0uVWyfs8D3x0/mftNVUAw7AoUf/xKwoELJeZEho8?=
 =?us-ascii?Q?FECDgXeH7pBULKS8pQ6n2IO28+0lmzjhe5MmuATru/a1v8EDFL7+fwr0n6bV?=
 =?us-ascii?Q?xROTPoHoAbqphaG4S5mkkXMmYqhGx9548MrPcGFkXapqgGQA2YZF4qXHswAF?=
 =?us-ascii?Q?H1Ua5w=3D=3D?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c579e18c-aabe-4089-bb99-08d9bca6693d
X-MS-Exchange-CrossTenant-AuthSource: ZRAP278MB0642.CHEP278.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2021 13:01:56.7385
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qhd9DjtR+cqGiuSYB2KwKQo2cxMPCY4tB98YhmfCYTiiOritmCCveCPDnTd2CUHFRddXZE0ZORpWhcsxBlzB+3lvAoUn+HkMsmVLniXvyQY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZRAP278MB0192
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Perform a PHY reset in phy_init_hw() to ensure that the PHY is working
after resume. This is required if the PHY was powered down in suspend
like it is done by the freescale FEC driver in fec_suspend().

Link: https://lore.kernel.org/netdev/20211206101326.1022527-1-philippe.schenker@toradex.com/
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

---

Philippe: what about something like that? Only compile tested, but I see no reason for this not solving the issue.

Any delay required on the reset can be specified using reset-assert-us/reset-deassert-us.

---
 drivers/net/phy/phy_device.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 74d8e1dc125f..7eab0c054adf 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1158,7 +1158,8 @@ int phy_init_hw(struct phy_device *phydev)
 {
 	int ret = 0;
 
-	/* Deassert the reset signal */
+	/* phy reset required if the phy was powered down during suspend */
+	phy_device_reset(phydev, 1);
 	phy_device_reset(phydev, 0);
 
 	if (!phydev->drv)
-- 
2.25.1