From:   David Laight <David.Laight@ACULAB.COM>
To:     'Arnaldo Carvalho de Melo' <acme@kernel.org>,
        Sohaib Mohamed <sohaib.amhmd@gmail.com>
CC:     "irogers@google.com" <irogers@google.com>,
        Riccardo Mancini <rickyman7@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        "Namhyung Kim" <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        "Fabian Hemmer" <copy@copy.sh>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] Unbuffered output when pipe/tee to a file
Thread-Topic: [PATCH v2] Unbuffered output when pipe/tee to a file
Thread-Index: AQHX7S22lFcMQTUX3UOhS5fSvE+CQawtiIpg
Date:   Sat, 11 Dec 2021 17:10:13 +0000
Message-ID: <8edd3fd7b40745b6bf96cbb6438fcc65@AcuMS.aculab.com>
References: <20211119061409.78004-1-sohaib.amhmd@gmail.com>
 <YbJQAp6/gz4kHdi8@kernel.org>
In-Reply-To: <YbJQAp6/gz4kHdi8@kernel.org>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Arnaldo Carvalho de Melo
> Sent: 09 December 2021 18:51
...
> > diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> > index 8cb5a1c3489e..d92ae4efd2e6 100644
> > --- a/tools/perf/tests/builtin-test.c
> > +++ b/tools/perf/tests/builtin-test.c
> > @@ -606,6 +606,9 @@ int cmd_test(int argc, const char **argv)
> >          if (ret < 0)
> >                  return ret;
> >
> > +	/* Unbuffered output */
> > +	setvbuf(stdout, NULL, _IONBF, 0);
> > +

You only want _IOLBF (line buffered).

Otherwise you are likely to get a lot of write() system calls.
Even multiple ones from the same printf().

Although it can be better just to ensure there is a fflush(stdout)
inside the loop.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)