MIME-Version: 1.0
References: <1638864419-17501-1-git-send-email-wellslutw@gmail.com>
 <1638864419-17501-2-git-send-email-wellslutw@gmail.com> <YbPHxVf1vXZj9GOC@robh.at.kernel.org>
In-Reply-To: <YbPHxVf1vXZj9GOC@robh.at.kernel.org>
From:   =?UTF-8?B?5ZGC6Iqz6aiw?= <wellslutw@gmail.com>
Date:   Sun, 12 Dec 2021 03:34:49 +0800
Message-ID: <CAFnkrsmXu9ceSQ7rzOAFy_kP6JMa7GvY7HCbT=_wfskH6wXuSw@mail.gmail.com>
Subject: Re: [PATCH net-next v4 1/2] devicetree: bindings: net: Add bindings
 doc for Sunplus SP7021.
To:     Rob Herring <robh@kernel.org>
Cc:     davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        p.zabel@pengutronix.de, Wells Lu <wells.lu@sunplus.com>,
        vincent.shih@sunplus.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Rob,

Thank you very much for your review.
Please see my replies below:

> Add bindings documentation for Sunplus SP7021.
>
[...]
> > +
> > +  interrupts:
> > +    description: |
> > +      Contains number and type of interrupt. Number should be 66.
>
> Drop. That's every 'interrupts' and the exact number is outside the
> scope of the binding.

Yes, I'll drop the descriptions next patch.
interrupts property will be:

  interrupts:
    maxItems: 1


[...]
> > +
> > +  mdio:
>
> Just need:
>
>        $ref: mdio.yaml#
>        unevaluatedProperties: false
>
> and drop the rest.

Yes, I'll modify mdio node next patch.
mdio node will be:

  mdio:
    $ref: mdio.yaml#
    unevaluatedProperties: false


> > +    type: object
> > +    description: external MDIO Bus
> > +
> > +    properties:
> > +      "#address-cells":
> > +        const: 1
> > +
> > +      "#size-cells":
> > +        const: 0
> > +
> > +    patternProperties:
> > +      "^ethernet-phy@[0-9a-f]+$":
> > +        type: object
> > +        description: external PHY node
> > +
> > +        properties:
> > +          reg:
> > +            minimum: 0
> > +            maximum: 30

Can I limit value of 'reg' to no more than 30?


> > +
> > +        required:
> > +          - reg
> > +
> > +additionalProperties: false
> > +
[...]
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    emac: emac@9c108000 {
>
> ethernet@9c108000 {

I'll modify it next patch.


[...]
> > 2.7.4
> >


Best regards,
Wells