Message-ID: <3f53c496-cddc-7d2d-cf2d-a492eb5be9b2@infradead.org>
Date:   Sat, 11 Dec 2021 11:47:04 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: rockchip_i2s_tdm.c:undefined reference to `clk_set_parent'
Content-Language: en-US
To:     Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
        kernel test robot <lkp@intel.com>
Cc:     kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
        Mark Brown <broonie@kernel.org>
References: <202112070621.TnLPiADU-lkp@intel.com>
 <13326272.At7iLaMNiz@archbook>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <13326272.At7iLaMNiz@archbook>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 12/7/21 03:32, Nicolas Frattaroli wrote:
> On Montag, 6. Dezember 2021 23:46:38 CET kernel test robot wrote:
>> [...]
>>
>> All errors (new ones prefixed by >>):
>>
>>    mips-linux-ld: sound/soc/jz4740/jz4740-i2s.o: in function `jz4740_i2s_set_sysclk':
>>    jz4740-i2s.c:(.text+0x3ec): undefined reference to `clk_set_parent'
>>    mips-linux-ld: jz4740-i2s.c:(.text+0x44c): undefined reference to `clk_set_parent'
>>    mips-linux-ld: sound/soc/rockchip/rockchip_i2s_tdm.o: in function `rockchip_i2s_tdm_calibrate_mclk.isra.0':
>>>> rockchip_i2s_tdm.c:(.text+0x10d4): undefined reference to `clk_set_parent'
>>>> mips-linux-ld: rockchip_i2s_tdm.c:(.text+0x1180): undefined reference to `clk_set_parent'
>>
> 
> According to some previous conversations I've stumbled upon[1],
> this appears to be due to certain MIPS configurations not
> implementing the clock API properly, so they don't provide a
> clk_set_parent despite advertising that they have support for
> clocks.
> 
> So my question is: do I need to care about this? This hardware
> will never be used on MIPS, and a lot of other drivers (as seen in
> the errors snippet from the test robot) have the same issue, and
> the problem is most likely not in my driver but in that specific
> configuration's clock API implementation.
> 
> 
> [1]: https://lore.kernel.org/lkml/8a41b718-a6f6-6b7f-1699-18ab619884c3@infradead.org/

Yes, AFAIK this is fixed by:

commit fc1aabb08886
Author: Randy Dunlap <rdunlap@infradead.org>
Date:   Sun Nov 14 17:20:51 2021 -0800

    mips: lantiq: add support for clk_get_parent()


I can't reproduce this build error with the provided config file
in a current kernel tree.

-- 
~Randy