Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932255AbXAWUTt (ORCPT ); Tue, 23 Jan 2007 15:19:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933004AbXAWUTt (ORCPT ); Tue, 23 Jan 2007 15:19:49 -0500 Received: from colo.lackof.org ([198.49.126.79]:36040 "EHLO colo.lackof.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932255AbXAWUTr (ORCPT ); Tue, 23 Jan 2007 15:19:47 -0500 Date: Tue, 23 Jan 2007 13:19:37 -0700 From: dann frazier To: Grant Coady Cc: Willy Tarreau , Santiago Garcia Mantinan , linux-kernel@vger.kernel.org, debian-kernel@lists.debian.org Subject: Re: problems with latest smbfs changes on 2.4.34 and security backports Message-ID: <20070123201936.GA26310@colo> References: <20070117100030.GA11251@clandestino.aytolacoruna.es> <20070117215519.GX24090@1wt.eu> <20070119010040.GR16053@colo> <20070120010544.GY26210@colo> <20070121230321.GC2480@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070121230321.GC2480@1wt.eu> User-Agent: mutt-ng/devel-r782 (Debian) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2236 Lines: 51 On Mon, Jan 22, 2007 at 12:03:21AM +0100, Willy Tarreau wrote: > Hi Grant ! > > On Mon, Jan 22, 2007 at 09:52:44AM +1100, Grant Coady wrote: > > On Fri, 19 Jan 2007 18:05:44 -0700, dann frazier wrote: > > > > >On Thu, Jan 18, 2007 at 06:00:40PM -0700, dann frazier wrote: > > >Ah, think I see the problem now: > > > > > >--- kernel-source-2.4.27.orig/fs/smbfs/proc.c 2007-01-19 17:53:57.247695476 -0700 > > >+++ kernel-source-2.4.27/fs/smbfs/proc.c 2007-01-19 17:49:07.480161733 -0700 > > >@@ -1997,7 +1997,7 @@ > > > fattr->f_mode = (server->mnt->dir_mode & (S_IRWXU | S_IRWXG | S_IRWXO)) | S_IFDIR; > > > else if ( (server->mnt->flags & SMB_MOUNT_FMODE) && > > > !(S_ISDIR(fattr->f_mode)) ) > > >- fattr->f_mode = (server->mnt->file_mode & (S_IRWXU | S_IRWXG | S_IRWXO)) | S_IFREG; > > >+ fattr->f_mode = (server->mnt->file_mode & (S_IRWXU | S_IRWXG | S_IRWXO)) | (fattr->f_mode & S_IFMT); > > > > > > } > > > > > client running 2.4.34 with above patch, server is running 2.6.19.2 to > > eliminate it from the problem space (hopefully ;) : > > grant@sempro:/home/other$ uname -r > > 2.4.34b > > grant@sempro:/home/other$ ls -l > > total 9 > > drwxr-xr-x 1 grant wheel 4096 2007-01-21 11:44 dir/ > > drwxr-xr-x 1 grant wheel 4096 2007-01-21 11:44 dirlink/ > > -rwxr-xr-x 1 grant wheel 15 2007-01-21 11:43 file* > > -rwxr-xr-x 1 grant wheel 15 2007-01-21 11:43 filelink* > > It seems to me that there is a difference, because filelink now appears the > same size as file. It's just as if we had hard links instead of symlinks. I was running into this yesterday - turns out that Debian's current smbfs package contains a patch that checks for user passed options, and disables unix capabilities in that case. It was added in 3.0.14a-4. I've filed a bug requesting the removal of this patch: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=408033 Grant: Do you know if are you running a version of smbfs w/ this patch? -- dann frazier - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/