Message-ID: <64e31a014f01755c618c9d126f006b01fbc66408.camel@perches.com>
Subject: Re: [PATCH] ALSA: jack: Check the return value of kstrdup()
From:   Joe Perches <joe@perches.com>
To:     xkernel <xkernel.wang@foxmail.com>, perex@perex.cz, tiwai@suse.com
Cc:     alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Date:   Sat, 11 Dec 2021 21:44:33 -0800
In-Reply-To: <tencent_3D368E118A8AF018A5B1FF16904166B2DC07@qq.com>
References: <tencent_3D368E118A8AF018A5B1FF16904166B2DC07@qq.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 2021-12-12 at 01:13 +0800, xkernel wrote:
> kstrdup() can return NULL, it is better to check the return value of it.
[]
> diff --git a/sound/core/jack.c b/sound/core/jack.c
[]
> @@ -509,6 +509,8 @@ int snd_jack_new(struct snd_card *card, const char *id, int type,
>  		return -ENOMEM;
>  
>  	jack->id = kstrdup(id, GFP_KERNEL);
> +	if (jack->id == NULL)
> +		return -ENOMEM;

jack should be freed too.

	if (!jack->id) {
		kfree(jack);
		return -ENOMEM;
	}

>  
>  	/* don't creat input device for phantom jack */
>  	if (!phantom_jack) {