Subject: Re: [PATCH v2 7/8] drivers/perf: arm_pmu: Handle 47 bit counters
To:     Marc Zyngier <maz@kernel.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Mark Rutland <mark.rutland@arm.com>, Will Deacon <will@kernel.org>,
        Sven Peter <sven@svenpeter.dev>,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Rob Herring <robh+dt@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dougall <dougallj@gmail.com>, kernel-team@android.com
References: <20211201134909.390490-1-maz@kernel.org>
 <20211201134909.390490-8-maz@kernel.org>
From:   Hector Martin <marcan@marcan.st>
Message-ID: <67468c6c-d799-f407-a3e6-5f86c14af400@marcan.st>
Date:   Sun, 12 Dec 2021 16:26:18 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211201134909.390490-8-maz@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: es-ES
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 01/12/2021 22.49, Marc Zyngier wrote:
> The current ARM PMU framework can only deal with 32 or 64bit counters.
> Teach it about a 47bit flavour.
> 
> Yes, this is odd.
> 
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
>   drivers/perf/arm_pmu.c       | 2 ++
>   include/linux/perf/arm_pmu.h | 2 ++
>   2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> index 295cc7952d0e..0a9ed1a061ac 100644
> --- a/drivers/perf/arm_pmu.c
> +++ b/drivers/perf/arm_pmu.c
> @@ -109,6 +109,8 @@ static inline u64 arm_pmu_event_max_period(struct perf_event *event)
>   {
>   	if (event->hw.flags & ARMPMU_EVT_64BIT)
>   		return GENMASK_ULL(63, 0);
> +	else if (event->hw.flags & ARMPMU_EVT_47BIT)
> +		return GENMASK_ULL(46, 0);
>   	else
>   		return GENMASK_ULL(31, 0);
>   }
> diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h
> index 2512e2f9cd4e..0407a38b470a 100644
> --- a/include/linux/perf/arm_pmu.h
> +++ b/include/linux/perf/arm_pmu.h
> @@ -26,6 +26,8 @@
>    */
>   /* Event uses a 64bit counter */
>   #define ARMPMU_EVT_64BIT		1
> +/* Event uses a 47bit counter */
> +#define ARMPMU_EVT_47BIT		2
>   
>   #define HW_OP_UNSUPPORTED		0xFFFF
>   #define C(_x)				PERF_COUNT_HW_CACHE_##_x
> 

Reviewed-by: Hector Martin <marcan@marcan.st>

-- 
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub