Date:   Sun, 12 Dec 2021 09:58:31 +0100
Message-ID: <s5ha6h6fbd4.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Bradley Scott <Bradley.Scott@zebra.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Jeremy Szu <jeremy.szu@canonical.com>,
        Hui Wang <hui.wang@canonical.com>,
        Werner Sembach <wse@tuxedocomputers.com>,
        Kailang Yang <kailang@realtek.com>,
        Cameron Berkenpas <cam@neo-zeon.de>,
        Sami Loone <sami@loone.fi>, Elia Devito <eliadevito@gmail.com>,
        alsa-devel@alsa-project.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Amp init fixup for HP ZBook 15 G6
In-Reply-To: <20211210192614.460529-1-Bradley.Scott@zebra.com>
References: <20211210192614.460529-1-Bradley.Scott@zebra.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 10 Dec 2021 20:26:12 +0100,
Bradley Scott wrote:
> 
> HP ZBook 15 G6 (SSID 103c:860f) needs the same speaker amplifier
> initialization as used on several other HP laptops using ALC285.
> 
> This commit also adds a new "alc285-hp-amp-init" model that can be used
> to apply this same amp init fixup to other devices by passing
> "hda_model=alc285-hp-amp-init" to the snd-sof-intel-hda-common module or
> "model=alc285-hp-amp-init" to the snd-hda-intel module, depending on
> which is being used.
> 
> Signed-off-by: Bradley Scott <Bradley.Scott@zebra.com>

Thanks for the patch.  Unfortunately, somehow your MUA broke the tabs
with spaces and the patch wasn't cleanly applicable.

Also, I prefer splitting the changes to two, the addition of a quirk
entry and the addition to the model string.  Then old stable kernels
have more chance to pick up.

Could you try to resubmit?  In the worst case, I can take the
attachments, too.


Takashi