Date:   Sun, 12 Dec 2021 10:00:33 +0100
Message-ID: <s5h8rwqfb9q.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Colin King (gmail)" <colin.i.king@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: ALSA: drivers: opl3: assignment of a pointer that is not used, probable bug
In-Reply-To: <fbae9be5-c847-0b6b-f755-312a2af1e285@gmail.com>
References: <fbae9be5-c847-0b6b-f755-312a2af1e285@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 11 Dec 2021 19:19:30 +0100,
Colin King (gmail) wrote:
> 
> Hi,
> 
> static analysis with scan-build has found an assignment to vp2 that is
> never used in function snd_opl3_note_on(),
> sound/drivers/opl3/opl3_midi.c as follows:
> 
>         if (instr_4op) {
>                 vp2 = &opl3->voices[voice + 3];
>                 if (vp->state > 0) {
>                         opl3_reg = reg_side | (OPL3_REG_KEYON_BLOCK +
>                                                voice_offset + 3);
>                         reg_val = vp->keyon_reg & ~OPL3_KEYON_BIT;
>                         opl3->command(opl3, opl3_reg, reg_val);
>                 }
>         }
> 
> sound/drivers/opl3/opl3_midi.c:399:3: warning: Value stored to 'vp2'
> is never read [deadcode.DeadStores]
>                 vp2 = &opl3->voices[voice + 3];
>                 ^     ~~~~~~~~~~~~~~~~~~~~~~~~
> 
> I suspect that references to vp in this if block should be to vp2, but
> I'm unsure if that is for all references or not, hence I'm reporting
> this issue.

Yes, the next vp->state > 0 check must be vp2->state > 0.
Care to submit a proper fix patch?


Thanks!

Takashi