MIME-Version: 1.0
References: <20211212114929.264905-1-jose.exposito89@gmail.com>
In-Reply-To: <20211212114929.264905-1-jose.exposito89@gmail.com>
From:   Ricardo Ribalda <ribalda@chromium.org>
Date:   Sun, 12 Dec 2021 13:25:23 +0100
Message-ID: <CANiDSCu==Z6xaFD0hM_gYj5fv+55FPe=rRvW1a7aQZO7p-wt9Q@mail.gmail.com>
Subject: Re: [PATCH] media: uvcvideo: Fix memory leak in uvc_gpio_parse
To:     =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>
Cc:     laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Jos=C3=A9

Thanks for your patch

On Sun, 12 Dec 2021 at 12:49, Jos=C3=A9 Exp=C3=B3sito <jose.exposito89@gmai=
l.com> wrote:
>
> Previously the unit buffer was allocated before checking the IRQ for
> privacy GPIO.
> In case of error, the unit buffer was leaked.
>
> Allocate the unit buffer after the IRQ to avoid it.
>
> Addresses-Coverity-ID: 1474639 ("Resource leak")
> Signed-off-by: Jos=C3=A9 Exp=C3=B3sito <jose.exposito89@gmail.com>
Fixes: 2886477ff987 ("media: uvcvideo: Implement UVC_EXT_GPIO_UNIT")
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/media/usb/uvc/uvc_driver.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/u=
vc_driver.c
> index 7c007426e082..9e83e2002710 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -1533,10 +1533,6 @@ static int uvc_gpio_parse(struct uvc_device *dev)
>         if (IS_ERR_OR_NULL(gpio_privacy))
>                 return PTR_ERR_OR_ZERO(gpio_privacy);
>
> -       unit =3D uvc_alloc_entity(UVC_EXT_GPIO_UNIT, UVC_EXT_GPIO_UNIT_ID=
, 0, 1);
> -       if (!unit)
> -               return -ENOMEM;
> -
>         irq =3D gpiod_to_irq(gpio_privacy);
>         if (irq < 0) {
>                 if (irq !=3D EPROBE_DEFER)
> @@ -1545,6 +1541,10 @@ static int uvc_gpio_parse(struct uvc_device *dev)
>                 return irq;
>         }
>
> +       unit =3D uvc_alloc_entity(UVC_EXT_GPIO_UNIT, UVC_EXT_GPIO_UNIT_ID=
, 0, 1);
> +       if (!unit)
> +               return -ENOMEM;
> +
>         unit->gpio.gpio_privacy =3D gpio_privacy;
>         unit->gpio.irq =3D irq;
>         unit->gpio.bControlSize =3D 1;
> --
> 2.25.1
>


--=20
Ricardo Ribalda