From:   "Jankowski, Konrad0" <konrad0.jankowski@intel.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net-next 9/9] ixgbevf: switch to
 napi_build_skb()
Thread-Topic: [Intel-wired-lan] [PATCH net-next 9/9] ixgbevf: switch to
 napi_build_skb()
Thread-Index: AQHX4I+Weuj+9VTpk0KS26ixn0HYwawu/G6A
Date:   Sun, 12 Dec 2021 13:47:39 +0000
Message-ID: <DM8PR11MB5621C77BBC2B7DD6FB7806B8AB739@DM8PR11MB5621.namprd11.prod.outlook.com>
References: <20211123171840.157471-1-alexandr.lobakin@intel.com>
 <20211123171840.157471-10-alexandr.lobakin@intel.com>
In-Reply-To: <20211123171840.157471-10-alexandr.lobakin@intel.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CpwliagJ+uimW+WzLmPleNxCqjqOJyUYpVsu/PVLhlFWXTsNINgHNZHeAtac?=
 =?us-ascii?Q?bzm1spQ5M7jLMIC1Lv8/KXo4nDe3NAsiPTmr/mfQmhmjLJ510aNpYfulGUWf?=
 =?us-ascii?Q?1T65SpO0exfLLKbpyjyEv0NgBH+UXX3N2jQBkfsnK4pJTthQW/E2pxZ1FW8F?=
 =?us-ascii?Q?He7bFZ2KaAjVZM2/Shh+UvhHfaDef7xXytLxezD4H9yEAYQUTnupQg//Y7Fx?=
 =?us-ascii?Q?pwCUqTiJwmDKoR7X8U7tdGN0IuhEKKFSFBA41x2kExh5K+XlTvH8HSVVNYPD?=
 =?us-ascii?Q?fcGWAtSuBrguZZZi0LiOut9HLypA+3wLaJZsTVrMbXCVVlSMA4jTOxW0j4bG?=
 =?us-ascii?Q?OX5CvWjRHuIz7yF0RAUlgYZWNSKy4V9dyhLVzYy8gq1S1uuTxXPoPSV/+W19?=
 =?us-ascii?Q?KlmzjhImNWqY9bA2bKMfoaHOKYbxG2AN98m8UzqvCDyvjhti2CznIh+r4moC?=
 =?us-ascii?Q?xZCROlYFqpLkaJl9lfQ2F6V805FYemRB1S51BZfMFR2KCdstrKUOr9X5hrmW?=
 =?us-ascii?Q?OyFrAWuK9Zy0hEDU2ReLkV7Qv7W9sErEd7vFTsIS1fIqY4csff5meT0nKczA?=
 =?us-ascii?Q?U81hCw/HubjRt4E7D56Bwwrc3iwju3G1rU+l2/lb5wbhHNXgi/ZKruoUMoBu?=
 =?us-ascii?Q?fpOTnwG90oo0AspEJhwDhC6XMKRJAejs53FTjhX+jo1dVOCNiZ0kuD17LwyH?=
 =?us-ascii?Q?G78QyCxzjSNdBt76VHkuKLLFj3pUa2/krSA3/e8VH4oktbbxTcbAEMRQyNt9?=
 =?us-ascii?Q?MyUfO/Y9M0kidBH6X5kuz2ZhCEcIfLoiVO3AJ06AKQqRmFu3G8eOOitRBJ7a?=
 =?us-ascii?Q?rXC9lCCQtaxdy6r+1Z7ssOJskdxhYH3XVWOv/GpZEIZlzWO1scqQ8khouSxS?=
 =?us-ascii?Q?lswoiEloFMZPpy8DPy3oP0r9oENgVIjh1WWkugHcLciXZR56IJ2b+EkQ5aeo?=
 =?us-ascii?Q?h5AKOErQ2hWAkmHfalBOshPrJAaaAzgH1P8zZ/zgkZxpYKtGmcRBwIyhBMOC?=
 =?us-ascii?Q?lLJvjb/8iq0K2Wk4OGzr4JNA/4bH6Pqqk+pOD9fB8TVRsq5b0w1Z1UNTX+gp?=
 =?us-ascii?Q?xPl3F2ugQf7Kg7Cxov0fiQ2HeNFiAO3QQh07vQ65sWb48pJjgk1+OKa8eAj9?=
 =?us-ascii?Q?J1Z71BM/uC4u3X5OH9KTih+AZcjN9l/J4xxWDTcyi7+BGL1oVbnOIwdQvo2e?=
 =?us-ascii?Q?r6+R2O7MXo/af4iXwZtsvKrHs4UY0mo1EzDkocOd9ep3b+tEnkoeZm2YlYJS?=
 =?us-ascii?Q?3Vto3HEGsUTvgMzzcz46n/a1P+MXB0pTpE9EoYgloIofvG+CwYar5NUlFBAv?=
 =?us-ascii?Q?uBR3CRM5AsK6KHALj5kLlFhgIUO97q1b//8hQgE0NLKNib9/Marhfn0ayOD6?=
 =?us-ascii?Q?7W9kf0bheOuf4QYdSuyfkQWfg5KgNYJkXeoznmuqZgWEubtdUx/ZjmO8o5t/?=
 =?us-ascii?Q?5Z/DQWUQgSFGREBzBXKRp/VX9re6Ug4SR8jIBOofhTDwTOFYi1jenKyHeOCu?=
 =?us-ascii?Q?nbv4TPOAf72WB/ki5VL3mFoFgzFBHPIqnBKufpaJd2YrsyjAgbnaph+rrWuc?=
 =?us-ascii?Q?4KoKfBfqgszaoi4MYr7vWWdwE2p/mJJ5dz3Tpl1PDaB3QnrKvNFCRpnIVCDT?=
 =?us-ascii?Q?nISASIypZmzXztyyvRtJTQ5RbX95yC/qLTLUqAvxPrJl1geecl3Qlua57pIq?=
 =?us-ascii?Q?eqTNPA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5621.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f851b6a-95f2-491c-9b6e-08d9bd75f685
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2021 13:47:39.3145
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ToE2WLcid8VKgIwS2P+zA2mhZnljGZrzF30YWjG2urBVziovWAHdLcu1EM0n4wiKES/R99O+aFuSkst0T0FDvA4eIdkNXnOvQxwV6ANC9I0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5639
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Alexander Lobakin
> Sent: wtorek, 23 listopada 2021 18:19
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Jakub Kicinski
> <kuba@kernel.org>; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH net-next 9/9] ixgbevf: switch to
> napi_build_skb()
>=20
> napi_build_skb() reuses per-cpu NAPI skbuff_head cache in order to save
> some cycles on freeing/allocating skbuff_heads on every new Rx or
> completed Tx.
> ixgbevf driver runs Tx completion polling cycle right before the Rx one a=
nd
> uses napi_consume_skb() to feed the cache with skbuff_heads of
> completed entries, so it's never empty and always warm at that moment.
> Switch to the napi_build_skb() to relax mm pressure on heavy Rx.
>=20
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index b1dfbaff8b31..ea73fb3026bc 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> @@ -944,7 +944,7 @@ static struct sk_buff *ixgbevf_build_skb(struct

Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>