MIME-Version: 1.0
References: <20211211180955.550380-1-colin.i.king@gmail.com>
In-Reply-To: <20211211180955.550380-1-colin.i.king@gmail.com>
From:   Ryusuke Konishi <konishi.ryusuke@gmail.com>
Date:   Mon, 13 Dec 2021 00:51:34 +0900
Message-ID: <CAKFNMokO9CA6n2veR9JOg7CbzvgUc6rDMofOu2aiU+CDTTsjoA@mail.gmail.com>
Subject: Re: [PATCH] nilfs2: remove redundant pointer sbufs
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     linux-nilfs <linux-nilfs@vger.kernel.org>,
        kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Dec 12, 2021 at 3:09 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> Pointer sbufs is being assigned a value but it's not being used
> later on. The pointer is redundant and can be removed. Cleans up
> scan-build static analysis warning:
>
> fs/nilfs2/page.c:203:8: warning: Although the value stored to 'sbufs'
> is used in the enclosing expression, the value is never actually read
> from 'sbufs' [deadcode.DeadStores]
>         sbh = sbufs = page_buffers(src);
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Looks good.
Will apply, thank you.

Ryusuke Konishi

> ---
>  fs/nilfs2/page.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nilfs2/page.c b/fs/nilfs2/page.c
> index bc3e2cd4117f..063dd16d75b5 100644
> --- a/fs/nilfs2/page.c
> +++ b/fs/nilfs2/page.c
> @@ -195,12 +195,12 @@ void nilfs_page_bug(struct page *page)
>   */
>  static void nilfs_copy_page(struct page *dst, struct page *src, int copy_dirty)
>  {
> -       struct buffer_head *dbh, *dbufs, *sbh, *sbufs;
> +       struct buffer_head *dbh, *dbufs, *sbh;
>         unsigned long mask = NILFS_BUFFER_INHERENT_BITS;
>
>         BUG_ON(PageWriteback(dst));
>
> -       sbh = sbufs = page_buffers(src);
> +       sbh = page_buffers(src);
>         if (!page_has_buffers(dst))
>                 create_empty_buffers(dst, sbh->b_size, 0);
>
> --
> 2.33.1
>