Subject: Re: [PATCH] fpga: stratix10-soc: fix typo in a comment
To:     Jason Wang <wangborong@cdjrlc.com>, hao.wu@intel.com
Cc:     mdf@kernel.org, yilun.xu@intel.com, linux-fpga@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211212031956.46029-1-wangborong@cdjrlc.com>
From:   Tom Rix <trix@redhat.com>
Message-ID: <c10b3af5-5371-a4c0-bbe6-a29b3c3573ee@redhat.com>
Date:   Sun, 12 Dec 2021 08:19:00 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20211212031956.46029-1-wangborong@cdjrlc.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 12/11/21 7:19 PM, Jason Wang wrote:
> The double `if' in the comment in line 288 is repeated. Remove one
> of them from the comment.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>   drivers/fpga/stratix10-soc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 357cea58ec98..e4f2e83a615b 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -285,7 +285,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
>   
>   	/*
>   	 * Loop waiting for buffers to be returned.  When a buffer is returned,
> -	 * reuse it to send more data or free if if all data has been sent.
> +	 * reuse it to send more data or free if all data has been sent.

This looks fine.

Reviewed-by: Tom Rix <trix@redhat.com>

>   	 */
>   	while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
>   		reinit_completion(&priv->status_return_completion);