MIME-Version: 1.0
References: <20211126202144.72936-1-romain.perier@gmail.com>
 <20211126202144.72936-7-romain.perier@gmail.com> <CAFr9PXmpKrcPXL=EdL-uGu0X3nZBrAVcBSDqSbaDEvRhE6Abiw@mail.gmail.com>
 <CABgxDo+pF0RKK+HL+MVv5s0pn1T9a9Mqp6uPEkT0YPEH9kvQqw@mail.gmail.com>
In-Reply-To: <CABgxDo+pF0RKK+HL+MVv5s0pn1T9a9Mqp6uPEkT0YPEH9kvQqw@mail.gmail.com>
From:   Daniel Palmer <daniel@0x0f.com>
Date:   Mon, 13 Dec 2021 01:44:25 +0900
Message-ID: <CAFr9PXnXHw2ppg8ZBrPVAxsW5YETyeS7ygrkpTmAKV9W58pTTw@mail.gmail.com>
Subject: Re: [PATCH 5/5] ARM: dts: mstar: Switch to compatible
 "mstar,ssd20xd-timer" on ssd20xd
To:     Romain Perier <romain.perier@gmail.com>
Cc:     Daniel Lezcano <daniel.lezcano@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        DTML <devicetree@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Romain,

On Mon, 13 Dec 2021 at 01:10, Romain Perier <romain.perier@gmail.com> wrote:
>> I just noticed this during testing. I think we should put this in
>> mstar-infinity2m.dts. All of the infinity2m chips use the same die
>> from what I can tell so if the ssd201/ssd202d needs this then anything
>> else that includes mstar-infinity2m.dtsi will too.
>
>
> Mhhh, makes sense.
> Do we keep the compatible "sstar,ssd20xd-timer" in this case ?
> Because this is true for either the SSR621D or the SSD201 or the SSD202D,
> so... what about "sstar,ssxd-timer", or something like this ?

I think for anything infinity2m specific we use "sstar,ssd20xd-timer"
as the SSD201 and SSD202D are the first chips we found this in.
The SSR621D might get some specific compatibles for things that only
it has broken out like the SATA.

Cheers,

Daniel