Message-ID: <89507f40-257d-9a17-231b-78460c3141a5@acm.org>
Date:   Sun, 12 Dec 2021 14:32:33 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] scsi: ufs: ufshcd-pltfrm: check the return value of
 kstrdup()
Content-Language: en-US
To:     xkernel <xkernel.wang@foxmail.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com
Cc:     alim.akhtar@samsung.com, avri.altman@wdc.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <tencent_D3914A6FFF832049CC70B9411CAD1492E108@qq.com>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <tencent_D3914A6FFF832049CC70B9411CAD1492E108@qq.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/11/21 10:14, xkernel wrote:
> kstrdup() can return NULL if some internal memory errors happen, so it
> is better to check the return value of it.
> 
> Signed-off-by: xkernel <xkernel.wang@foxmail.com>

Is xkernel the name of a person or the name of a robot? Patches should 
be signed by a person even if these have been generated by a robot.

> +		clki->name = kstrdup(name, GFP_KERNEL);
> +		if (!clki->name) {
> +			ret = -ENOMEM;
> +			devm_kfree(dev, clki);
> +			goto out;
> +		}

Is the devm_kfree() call necessary? Is it useful?

Thanks,

Bart.