Date:   Mon, 13 Dec 2021 00:03:29 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     zweiss@equinix.com,
        Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Tomer Maimon <tmaimon77@gmail.com>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 5/8] pinctrl: nuvoton: Add driver for WPCM450
Message-ID: <YbZ/wQJwPDIS5fUr@latitude>
References: <20211207210823.1975632-1-j.neuschaefer@gmx.net>
 <20211207210823.1975632-6-j.neuschaefer@gmx.net>
 <CAHp75Vew=M_ofNM5pmeHtTJHXRUbbO4RrtgYAtLBznTBm3CS6Q@mail.gmail.com>
 <YbC6Bv2teZ5CFhFQ@latitude>
 <20211209082623.GF25091@packtop>
 <CACRpkdb_zGz4+8R0=ORCbbbVeJVkLqBG2CDXAzi2VAA7-PPZ6A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="30EHFckTS99T6vMB"
Content-Disposition: inline
In-Reply-To: <CACRpkdb_zGz4+8R0=ORCbbbVeJVkLqBG2CDXAzi2VAA7-PPZ6A@mail.gmail.com>
Precedence: bulk


--30EHFckTS99T6vMB
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 10, 2021 at 02:41:45AM +0100, Linus Walleij wrote:
> On Thu, Dec 9, 2021 at 9:26 AM Zev Weiss <zweiss@equinix.com> wrote:
> > On Wed, Dec 08, 2021 at 05:58:30AM PST, Jonathan Neusch=C3=A4fer wrote:
>=20
> > >> BIT()
> > >
> > >I'll use it, but in this case, I think it doesn't simplify much the
> > >whole expression all that much. Is there perhaps a macro that
> > >constructs a continuous bitmask of N bits, perhaps additionally
> > >left-shifted by M bits?
> > >
> > >Maybe somewhere in the bitmap_* API...
> > >
> >
> > There's GENMASK(), though it takes a high bit and low bit rather than a
> > bit position and count, so it'd require a small bit of arithmetic, e.g.
> >
> >   lastbit =3D gpio->first_irq_bit + gpio->num_irqs - 1;
> >   ours =3D GENMASK(lastbit, gpio->first_irq_bit);
> >
> > or a manual shift:
> >
> >   ours =3D GENMASK(gpio->num_irqs - 1, 0) << gpio->first_irq_bit;
>=20
> I think this can be handled with FIELD_PREP() from
> <linux/bitfield.h>? Some examples at the top of the
> header.

Thank you both!

Best regards,
Jonathan

--30EHFckTS99T6vMB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmG2f8EACgkQCDBEmo7z
X9vyUQ//br+ESQtfq4JlJ6O3bLYKACQe7YaNJu423ivv1HwZ8cBzvRLdFgSwPxbM
JwAkXckp05zpRHzp/0WYDsvy16yPlTAoyrLlnqyKuesXIB4Z/EM2aVNtu4dv+Wbl
fMAt3epKy2ZjT7fPooRm0ySjJdq3d2uzu7fVCo+VMWpRZmXrrUVsphPeNKjS/16f
YQHswQMJ9oSDlL3cfugjtz0AOoZ/XyKtKfbcS4uE9lgTq9V5Bj9IiEopv4GDMRhG
eQVItYAukQ0oTxqned+qom4U+RcuJgrel8p5C/ZQojQ3XVYiqvDZWiStk5fkDIt8
IrrPJt1psBE4/O3r6utoo/I9LbctYoy69E5pIvo/IUELfkngzFQu6w+eIL+ndAIx
vKWMJYzAOWY3l94tQqvu3zPloZhbAXmvt5V49r8YQnNXsb7QCGSo7as8/tkT3nIQ
bFXsZarXI6b8tGwUpj4TCgISIG2TojxAZOSxPg/7zUnxXY2O4A2bbuSoumFiDlN3
PhiwUg+6oCZ1EZS4bOhdqrRm/h+7ZVSJxlFnAyeV5bFeW84B3CQzQ7nDtsPK6N4i
oc/McWrIBMt5qKw08eXi2PrE9HrqDcKEhkck45NVR8NsX9+5O9U0Jg5FNHxN64f+
4oqgPpe9vxeinHIrSWs5yTJ1Q1a7c8adb4P7bGeCEWp9aXGvLgI=
=6U2z
-----END PGP SIGNATURE-----

--30EHFckTS99T6vMB--