From:   "Chanho Park" <chanho61.park@samsung.com>
To:     "'Sam Protsenko'" <semen.protsenko@linaro.org>,
        "'Wolfram Sang'" <wsa@kernel.org>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>
Cc:     "'Jaewon Kim'" <jaewon02.kim@samsung.com>,
        <linux-i2c@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
In-Reply-To: <20211212181057.20210-1-semen.protsenko@linaro.org>
Subject: RE: [PATCH] i2c: exynos5: Fix getting the optional clock
Date:   Mon, 13 Dec 2021 09:00:48 +0900
Message-ID: <000001d7efb4$7c608110$75218330$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQK4K353fFNOeF7AtoqnQ2/nmI3enQH8YxdZql8unEA=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20211212181103epcas2p2f366435198200c3f4bac0fdf8ad1d0a3@epcas2p2.samsung.com>
        <20211212181057.20210-1-semen.protsenko@linaro.org>
Precedence: bulk

> "hsi2c_pclk" clock is optional and may not be present for some SoCs
> supported by this driver. Nevertheless, in case the clock is provided but
> some error happens during its getting, that error should be handled
> properly. Use devm_clk_get_optional() API for that. Also report possible
> errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if
> clock provider is not ready by the time I2C probe function is executed).
> 
> Fixes: c93ac09df2a8 ("i2c: exynos5: Add bus clock support")
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

Reviewed-by: Chanho Park <chanho61.park@samsung.com>