From:   Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     Joakim Zhang <qiangqing.zhang@nxp.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
        "alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
        "joabreu@synopsys.com" <joabreu@synopsys.com>,
        Yannick Vignon <yannick.vignon@nxp.com>,
        "boon.leong.ong@intel.com" <boon.leong.ong@intel.com>,
        "Jose.Abreu@synopsys.com" <Jose.Abreu@synopsys.com>,
        "mst@redhat.com" <mst@redhat.com>,
        "Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
        Mingkai Hu <mingkai.hu@nxp.com>, Leo Li <leoyang.li@nxp.com>
Subject: RE: [EXT] Re: [PATCH net-next] net: stmmac: bump tc when get
 underflow error from DMA descriptor
Thread-Topic: [EXT] Re: [PATCH net-next] net: stmmac: bump tc when get
 underflow error from DMA descriptor
Thread-Index: AQHX7Bmwj7VotTMrk0auLbMKkiRGRqwpYOIAgAGlwYCAAAEj4IAA39cAgAOzRbA=
Date:   Mon, 13 Dec 2021 00:49:03 +0000
Message-ID: <DB8PR04MB5785AC0B2197DC4EBD28B146F0749@DB8PR04MB5785.eurprd04.prod.outlook.com>
References: <20211208100651.19369-1-xiaoliang.yang_1@nxp.com>
        <VI1PR04MB68009F16CAA80DCEBFA8F170E6709@VI1PR04MB6800.eurprd04.prod.outlook.com>
        <20211209184123.63117f42@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <DB8PR04MB57852B80794A0B487167D3A2F0719@DB8PR04MB5785.eurprd04.prod.outlook.com>
 <20211210080636.3c1ab98f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20211210080636.3c1ab98f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+Al2rneXR5k+YmMWTkN/h4XRSqCQwP4kc79a1XI+iczvKQ7abiBeHvzSX0tN?=
 =?us-ascii?Q?NDuhJTuSOZOBTxiv4+8M67WhUf/VteEandVDWconsdW8Fw2ngN6u3/MWb/b5?=
 =?us-ascii?Q?RMyUpLaIvDSw0wL6GgqZCvQhiPrXdIcf++VsIInOOS/PKotXvntYKklRWniq?=
 =?us-ascii?Q?wBQjftqOk+z4iU4urwPROuuYbgodxtdivM/9WuGGrQ+oMfNUFjK02fv2XkQT?=
 =?us-ascii?Q?xIlZxZECW8Zk0q9h7mDAPm1d08NSiPDPHBKuv+d7n8L1J9fuG4IEVmM3G1TQ?=
 =?us-ascii?Q?YvT9cu/giTewRDPzhy3EA/+LtpR1MDuDDlxTGKkyqhyH9tD5MFQMk1yWpGu7?=
 =?us-ascii?Q?faiDAWFxh03B+3SE8x+0uSpHQDaN26bm5N7GBnWBIhpKWfM1ijw57hGDB00f?=
 =?us-ascii?Q?Xy1FnS0e4Z5oB9RpPjpfMh9UcREUtfupSS3+jOjJj/0Myh6Q1XOZyOU1Pgud?=
 =?us-ascii?Q?VVHFL1QaonYe1ffl2ZsqR0VKYo/qVttu/F4iArK30nmUnNsnRLMV0nkTRrxh?=
 =?us-ascii?Q?0FDTPht/792+q3FkRo0mFh8i2T/rTDQUfL22rBa8ZOIosxUH8Zip16yYBcCY?=
 =?us-ascii?Q?JgIgOAxv4scuxxe17MpBN5EZtrqM18G6zpId2rUrI7AQ+4qEHwPlPY+ckH6m?=
 =?us-ascii?Q?rKQjXQJOZhzsVff4no7q4nPkX24a9Q8i4Bo+raH9ioXgB6/MSwfvmiy7i3PR?=
 =?us-ascii?Q?noVQceF7ivJNFYgyRA8F4oF9bpzZ11/j5DLW6TAO+Bfl/POhD2CbGlWRfvxw?=
 =?us-ascii?Q?/xee9wDW8peLAOhwAnf5NKlWO+3jMqyL0W9yT19A5v4R1Pu89JqE/nvLcigK?=
 =?us-ascii?Q?Whf4HVYkiE7cOCKqvNk2yRI1wRYKZPURW1XfrTVJwNyUu0WP6MO5KxKfMn61?=
 =?us-ascii?Q?ADqhbL6eBJQvssmN2TGhT/4Kph1X72qSWzTaaxSseqFb1JTpPg11AtbfNi17?=
 =?us-ascii?Q?cPORYNWKujc2ms5l0jVjxlZUurJ+RIZjq1aau2orpgDQF3Ol1IsxUoD4290B?=
 =?us-ascii?Q?Q5c3dZbPY3ghbtUloRn1fyOSPlxuwRw9woVEOymU7bQ8WJ/Da5yaFY/zONDp?=
 =?us-ascii?Q?pDX9IxWApiqu4ayrWe5/K6dLsR5CDpsd2Xq2nmENOgeLpss7kFKTKJLh3EEL?=
 =?us-ascii?Q?/9yD5e8rp/9VRHJo5gm1bo9Js59tOCABkUApMp0bIbp9Unt7RSa7cOVlr0oh?=
 =?us-ascii?Q?67hMBdGIYZMHOFg7eV0k6sZJV18M6imHzEGv5he+gZXNjRT58UWoxuHXCfV/?=
 =?us-ascii?Q?xSo5OiYIWwIf34pJJthviK2onnoihwwQwZK1GyBxXOq/c66aaFApvtaFQed5?=
 =?us-ascii?Q?V7TBlY1CfW5ueqsJqBidy9HpMK1D/IYb9c+lSmKwr0+EPdOHmkAMTlLq54Ft?=
 =?us-ascii?Q?grpgDeRHi3xiKbE6NfFMIP/ChcoKpLoJQlNT04UyUINPHGODmUy2XHpsS4r9?=
 =?us-ascii?Q?CZEIwyFbqy9wX8BE2wrLhKgio7q3PdXUsDHCdXqxnaAegDgNn+y+6CrZW6rl?=
 =?us-ascii?Q?vXJquLXsMZK0AO1iOOa4mrEMfQT3XZGykG7vdJ//aodY/6oU8umoVEMdACkv?=
 =?us-ascii?Q?1l1MOilFUBtVZbkcULh/4n/uMJhTORKKW57fGM8SjvryoABpmFnOHOUetK1A?=
 =?us-ascii?Q?/Pthn1jgEb21r4aUik8EXyXIL/wu3lxv0aZeOUFctnNKX2Red7Y7ArxBzI0C?=
 =?us-ascii?Q?lk6tKQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB5785.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0a062bc-94da-437b-068b-08d9bdd25c86
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2021 00:49:03.9986
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wk8dDGxxfRnI7IMV7ZUzUAi2teHhb5prvqNk3oihHtmW18Ux4dsPxNfFznH9XOjGe0WVv1w6rE3z3bpoyhQXhf/KCgBGw5qXj6ph+N9BWuA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6137
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Fri, 11 Dec 2021 00:07:13 Jakub Kicinski wrote:
> > > > 5 queues with FIFO cut-through mode can work well after applying th=
is
> patch.
> > >
> > > This never worked, correct? It's not a regression fix?
> >
> > Yes, it's never worked when the underflow error is observed in the
> > case of NFS boot on i.mx8mp. I'm not sure if other SoC have same issue
> > in this case, but I think it's necessary to increase the threshold
> > value in case of underflow error.
>=20
> Oh, so NFS boot works for the most part on i.mx8mp but under certain
> conditions (or with certain configuration?) this error can be observed an=
d the
> boot will fail?
Yes, when configure the DMA as threshold mode, this error can be observed.

>=20
> > Do you mean that I need to send the patch as a bug fix to net branch?
>=20
> Your call, if you would like for the patch to go to stable and LTS releas=
es -- then
> it need to be resent for net with a Fixes tag.
>=20
> LMK if you prefer net or net-next.
Because this error requires a certain condition in DTS file, and I haven't =
update the DTS file. So I prefer to add the patch in net-next, thanks.