Date:   Mon, 13 Dec 2021 09:28:46 +0800
From:   Xu Yilun <yilun.xu@intel.com>
To:     Tom Rix <trix@redhat.com>
Cc:     Jason Wang <wangborong@cdjrlc.com>, hao.wu@intel.com,
        mdf@kernel.org, linux-fpga@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: stratix10-soc: fix typo in a comment
Message-ID: <20211213012846.GD336280@yilunxu-OptiPlex-7050>
References: <20211212031956.46029-1-wangborong@cdjrlc.com>
 <c10b3af5-5371-a4c0-bbe6-a29b3c3573ee@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c10b3af5-5371-a4c0-bbe6-a29b3c3573ee@redhat.com>
Precedence: bulk

On Sun, Dec 12, 2021 at 08:19:00AM -0800, Tom Rix wrote:
> 
> On 12/11/21 7:19 PM, Jason Wang wrote:
> > The double `if' in the comment in line 288 is repeated. Remove one
> > of them from the comment.
> > 
> > Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> > ---
> >   drivers/fpga/stratix10-soc.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> > index 357cea58ec98..e4f2e83a615b 100644
> > --- a/drivers/fpga/stratix10-soc.c
> > +++ b/drivers/fpga/stratix10-soc.c
> > @@ -285,7 +285,7 @@ static int s10_ops_write(struct fpga_manager *mgr, const char *buf,
> >   	/*
> >   	 * Loop waiting for buffers to be returned.  When a buffer is returned,
> > -	 * reuse it to send more data or free if if all data has been sent.
> > +	 * reuse it to send more data or free if all data has been sent.
> 
> This looks fine.
> 
> Reviewed-by: Tom Rix <trix@redhat.com>

Acked-by: Xu Yilun <yilun.xu@intel.com>

Thanks,
Yilun

> 
> >   	 */
> >   	while (count > 0 || s10_free_buffer_count(mgr) != NUM_SVC_BUFS) {
> >   		reinit_completion(&priv->status_return_completion);