Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "OGAWA Hirofumi" <hirofumi@mail.parknet.co.jp>
Cc:     linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        "Christoph Hellwig" <hch@infradead.org>
Subject: Re: [PATCH v2] FAT: use schedule_timeout_uninterruptible() instead of
 congestion_wait()
In-reply-to: <875yrtql2s.fsf@mail.parknet.co.jp>
References: <163712349419.13692.2859038330142282757@noble.neil.brown.name>,
 <87ee79yiik.fsf@mail.parknet.co.jp>,
 <163754226639.13692.10449616189734943162@noble.neil.brown.name>,
 <874k84hi5q.fsf@mail.parknet.co.jp>,
 <163911011670.9928.6438117555175130033@noble.neil.brown.name>,
 <163911016975.9928.6568675782275129@noble.neil.brown.name>,
 <87h7bfmtqc.fsf@mail.parknet.co.jp>,
 <163936252397.22433.9103044991910658320@noble.neil.brown.name>,
 <875yrtql2s.fsf@mail.parknet.co.jp>
Date:   Mon, 13 Dec 2021 13:49:07 +1100
Message-id: <163936374739.22433.3300471788473733689@noble.neil.brown.name>
Precedence: bulk

On Mon, 13 Dec 2021, OGAWA Hirofumi wrote:
> "NeilBrown" <neilb@suse.de> writes:
>=20
> > On Sat, 11 Dec 2021, OGAWA Hirofumi wrote:
> >> "NeilBrown" <neilb@suse.de> writes:
> >>=20
> >> > congestion_wait() in this context is just a sleep - block devices do n=
ot
> >> > in general support congestion signalling any more.
> >> >
> >> > The goal here is to wait for any recently written data to get to
> >> > storage.  blkdev_issue_flush() is thought to be too expensive, so
> >> > replace congestion_wait() with an explicit timeout.
> >>=20
> >> If just replace, the following looks better
> >>=20
> >> 	set_current_state(TASK_UNINTERRUPTIBLE);
> >> 	io_schedule_timeout(HZ/10);
> >>=20
> >> Otherwise,
> >>=20
> >> Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> >
> > Thanks.
> > According to MAINTAINERS, I should send patches for this code to you,
> > with the implication (I assumed) that you would forwarded them upstream
> > if acceptable.
> > But the fact that you have send mt an Acked-By seems to suggest that you
> > won't be doing that.
> > To whom should I send this patch with your acked-by?
>=20
> Ah, sorry. I have no repository. So FAT patches goes to linus tree via
> akpm's help.
>=20
> So "Cc: Andrew Morton <akpm@linux-foundation.org>" and my Acked-by
> should work (or I will Cc as reply if need).

Will do, thanks.

NeilBrown