From:   "Wu, Hao" <hao.wu@intel.com>
To:     "Xu, Yilun" <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
        Miaoqian Lin <linmq006@gmail.com>
CC:     "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mdf@kernel.org" <mdf@kernel.org>
Subject: RE: [PATCH v2] fpga: stratix10-soc: fix NULL vs IS_ERR() checking
Thread-Topic: [PATCH v2] fpga: stratix10-soc: fix NULL vs IS_ERR() checking
Thread-Index: AQHX7p5/xsSLfKUU10O4avfyee3PtawtYbKAgAJCegCAAEgu8A==
Date:   Mon, 13 Dec 2021 06:12:38 +0000
Message-ID: <DM6PR11MB3819B3918DA4D58E59228CAC85749@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <b1186cd9-c29c-397b-080b-dcfc6b02525f@redhat.com>
 <20211211145038.31612-1-linmq006@gmail.com>
 <97789bcc-0e5b-a822-854f-15d0fbe47844@redhat.com>
 <20211213012818.GC336280@yilunxu-OptiPlex-7050>
In-Reply-To: <20211213012818.GC336280@yilunxu-OptiPlex-7050>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.200.16
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d8x5e0ZONhWdH9Z8X4qEmchv0uw5a7wPmtKFE8lyfppsBxxQwYGhbSq3NcYk?=
 =?us-ascii?Q?j8Aj5ifUWlT3FZ4gEoQx6OpCrzxVrReoR4/f4BhCcw+yazn4JxElkUT4nF2s?=
 =?us-ascii?Q?s0fLyt4dTlfSWRxljQ6mNBRAmNsplNuMF7F8WzXYzBLDxytW2d4XSAebfqw9?=
 =?us-ascii?Q?ETDy3To+bmtfkmChfZ+Xnx8TxafWJKT002nwtreYZNEaTNgHgieBYejyh77t?=
 =?us-ascii?Q?krfpFTg/Qo9QJBnjJmOGu7K9lXThtnl9Jp2M6jtFhnIoZp/qxJe5veQRi+Fe?=
 =?us-ascii?Q?Eno8UfK7jpEUM76ySopBZL6ky1dq9gCWjVeCxTwf31H0TDBs5SC2h1yjJNOS?=
 =?us-ascii?Q?fyKxUTMr7fNw0fH2qlUPaEjtBx0zbmPOj1SS3XTEXlJuMKCtOAf+1OHz5foC?=
 =?us-ascii?Q?bXLOqEBbeqgYRSMbhwc3Bq1XMxV0Kc8H9UK4CQ9QRWA9HiPikcSdYYB658hO?=
 =?us-ascii?Q?bTOkgrKlWboS6YgRS4VfEczDuU9TPTGq7GOpfUHQmmSUkio8zkCZA5Y07igm?=
 =?us-ascii?Q?DY0d7/DCSD5V7QeA8EOYB2l6cXXiLnnwUl6X0KlwSioLeU3hImHuQut4aDrk?=
 =?us-ascii?Q?lptnegrKnuERh+358fx8wYn8oaudRWH2b0QTlGOd0xwjd76+mzYyYfXoOpAW?=
 =?us-ascii?Q?AjnPpDb+O0gCddzuVqqH7+EoLQYl07c1fB2S2gLpbK4Z+bEg2TBTF91CmPU6?=
 =?us-ascii?Q?KwXXAb427TWBNCfDy8IiYIm98pcctXvQ4bjwndTooIMlgrqsU+5E5zg02DIa?=
 =?us-ascii?Q?encBBR+mDW+KOboz+sZiZ59SqfQE3VEeQiILsrSbDHdNmOGUVxwItjHjC4Zh?=
 =?us-ascii?Q?iWXbS6lfuLzloYESrbCfFLIWrf6UFynu6AhxH2svHGCCduJI5+HreCSjRS2x?=
 =?us-ascii?Q?KV8q37opEzlBiFqkRiNPZu+DyFuzpPm10wlRnZxfshPJ41c62fIEXi8HyXra?=
 =?us-ascii?Q?Nl3Jq0gNBiAoibAwTooAEzZAkh9WvAC1m6oJ3vSz5P4cxjjLGqz2CIkrcQod?=
 =?us-ascii?Q?pKGN9ss4ePIs7H2E7c7aLV/JhULCffsxGxd9qXLv4CofR7gJfSqXIg1n23YC?=
 =?us-ascii?Q?GJ1JBfqs9vIWPUACN9763/tbL7k8tcmdT507CQOFvtJlDrEfKltf5JfJzYdv?=
 =?us-ascii?Q?VVvC+3WukrlIf8ctli12xvcejIMSUttMhL4WieH0IvrWMYvdl9kGjnQGGRMU?=
 =?us-ascii?Q?A/Tm+k5sP00tPQpuSBcjMzwfdTxKnNz36sDEACpwQi2xFGS2VDMD+bz3Zx9s?=
 =?us-ascii?Q?JTTScFR1S9QfHVEx6ru+Qg8u1+b6f5UV2poe9qKDvDA9/dvmee/juvUwm+43?=
 =?us-ascii?Q?W/j5Vucdiosh2OhO/CLqoSyBbwTGykHs95sfiEWEvOSuQ5CW+/yA+C1tH2y+?=
 =?us-ascii?Q?iFZnrSw9RDCGPQn+ZG/SL0ppn19RoRFGx76sYhpLknONtgkbqDd5S7+uA9f/?=
 =?us-ascii?Q?GhbxjPG9pEBBLLxOWPx2nsm1V+BCHlZWtFj5xJPlbDtLDp8M2uNPp6dvszLg?=
 =?us-ascii?Q?LuzuJlb+A14xOzkFGrMdpN28R1Tgj9QyPqG5Et9qpUpN3zZbPCdeTQGJHhVn?=
 =?us-ascii?Q?Vzg+oFnIeeWe3vaTCGQxVLNXB5qRvEGSHwoU2VW/TVcbK0VMFpd9omHAKlI/?=
 =?us-ascii?Q?VA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41a4fe12-04a8-499f-0e2f-08d9bdff9036
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2021 06:12:38.2468
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ls7LOT+Bfgpm5SNlhhx6r71a9qCsUYhG6IOJNaDBtPEPu6GeWh+XgOUVxFuExjT4NR5GUT7Sp9qxL6e/HaxaDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2649
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > On 12/11/21 6:50 AM, Miaoqian Lin wrote:
> > > The stratix10_svc_allocate_memory function does not return NULL. It
> > > returns ERR_PTR(-ENOMEM). Use IS_ERR check the return value.
> > >

Please add "Fixes" tag, then
Acked-by: Wu Hao <hao.wu@intel.com>

Thanks for the patch.
Hao

> > > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> > > ---
> > >   drivers/fpga/stratix10-soc.c | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-so=
c.c
> > > index 047fd7f23706..91212bab5871 100644
> > > --- a/drivers/fpga/stratix10-soc.c
> > > +++ b/drivers/fpga/stratix10-soc.c
> > > @@ -213,9 +213,9 @@ static int s10_ops_write_init(struct fpga_manager
> *mgr,
> > >   	/* Allocate buffers from the service layer's pool. */
> > >   	for (i =3D 0; i < NUM_SVC_BUFS; i++) {
> > >   		kbuf =3D stratix10_svc_allocate_memory(priv->chan,
> SVC_BUF_SIZE);
> > > -		if (!kbuf) {
> > > +		if (IS_ERR(kbuf)) {
> > >   			s10_free_buffers(mgr);
> > > -			ret =3D -ENOMEM;
> > > +			ret =3D PTR_ERR(kbuf);
> >
> > Thanks!
> >
> > Reviewed-by: Tom Rix <trix@redhat.com>
>=20
> Acked-by: Xu Yilun <yilun.xu@intel.com>
>=20
> Thanks,
> Yilun
>=20
> >
> > >   			goto init_done;
> > >   		}