Date:   Mon, 13 Dec 2021 10:40:31 +0100
Message-ID: <s5hk0g8etbk.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Xiaoke Wang <xkernel.wang@foxmail.com>
Cc:     joe@perches.com, perex@perex.cz, tiwai@suse.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: jack: Check the return value of kstrdup()
In-Reply-To: <tencent_094816F3522E0DC704056C789352EBBF0606@qq.com>
References: <tencent_094816F3522E0DC704056C789352EBBF0606@qq.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 13 Dec 2021 08:39:31 +0100,
Xiaoke Wang wrote:
> 
> kstrdup() can return NULL, it is better to check the return value of it.
> Fix: free jack and use my full name.
> 
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>

Thanks, applied now with Cc-to-stable.

BTW, when you submit a revised patch, please put 'v2' or such to the
patch subject prefix, e.g.
  [PATCH v2] ALSA: jack: ...

Also you can put the note about the changes between revisions as

  v1->v2: Fix something more....

and this could be put after the first '---' line (around the diffstat)
if it's not necessarily to be included in the final commit log.


Takashi