From:   Qing Wang <wangqing@vivo.com>
To:     Russell King <linux@armlinux.org.uk>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Ludovic Desroches <ludovic.desroches@microchip.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] arm: mach-at91: add missing of_node_put
Date:   Mon, 13 Dec 2021 01:41:56 -0800
Message-Id: <1639388520-63567-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?89HBHqy8TzHHyFapEnepMxYqJtHtYgh2sis34gz+DOlcz5QYNColRDiLG1Fo?=
 =?us-ascii?Q?oo5v57UX61F2ET89ohUI+zXicpxXTXN7E1W4QDSRT7a7CJIIOXIUMlKPLEEd?=
 =?us-ascii?Q?hIPo657UspnAEwpPYAySWvZi6Nmg6AdoIkl2wRQ3hoq3cOoXTBi7FmzDhoTO?=
 =?us-ascii?Q?V+VtqvGTsLCuor8zwxS/C4NegNPEC6i0U004iZ9gu3oHBh/9Otij4r37y7Au?=
 =?us-ascii?Q?Pjul/Kg4vATj7haKje2/HTB+f/qgy0S5q0FQhwRqjabkONBRUXVIF5ZgLFgC?=
 =?us-ascii?Q?mVw4TeODzGM9PmomtOZB6Ix/MNm4MZ9W6PG3hEkLzBDlaEl9l+d+NkxGpZM+?=
 =?us-ascii?Q?D1U1BGsEhzSsjz9s49ONCvwGFs7Hi97kQfzEctmS36XsfdtGJcGz86JioECQ?=
 =?us-ascii?Q?7wuT5VjJVooaMtXee8l4nXW3L3uxLvgludTFGfAwUPYJOgp+QqNp+Gu9BSg1?=
 =?us-ascii?Q?B/4fw9orrI/frpUbqJ0YKsCl1wx5Y1iYwhnpy/jWNASq/CTQmKm4KdvvKXRf?=
 =?us-ascii?Q?Tac30X6eKJlwe9GrL1Jx0F52ZVRGEzjMUoQEe6ybL3n5Vti9o2hmO/292lUz?=
 =?us-ascii?Q?oaL+rDnrRLRCehS6XCqkQflto34jvYhTW616fj+6kJMjrDuBRmHguW6hZIML?=
 =?us-ascii?Q?eGbHA7OkEEZUHzjLehW0L3k2QIUZb7aCPr8xvRuBTyF+sMkazhBotZDxmqEH?=
 =?us-ascii?Q?s3PFJllfl+Mx2mUiSodr+WLTeXp5b/jLEofd752J27p/wiEo8/spUFD96K/e?=
 =?us-ascii?Q?jG0ngEuYkOSMK7ti1aDFDxoIQWhtZDByATjmSCBTwF9Lb3PemwBrMUZrWLV+?=
 =?us-ascii?Q?9sXz0DR+wT8H/LrQJRLGTfZ/iAgcaQmQdjIpeW0i38+wT4v9vyRfLCs7mX/l?=
 =?us-ascii?Q?zi2vQenZKEu6L3qo7bMKYxXlb1r4T1iBy2LiAQsaCZDVTCOdP2mLZwoynVxl?=
 =?us-ascii?Q?r7/UtubcrIq/6PJkeDWaVgvc9ht7fNxxwSyCWRKCY8jEHMspPyU28Y2p5nCd?=
 =?us-ascii?Q?4tkncs9uYJmNwAIaauT4KixOE47AkZQmxXiqaW3QaWpZlvbksuDLPGlRtY3h?=
 =?us-ascii?Q?sUhAbiAqUSgojCl1ifdHGa5qENhETjbn30ZwcIWkQ7zTUtwrI8q+JW3T1Z2o?=
 =?us-ascii?Q?oJ0ODUg4S+k9+4rX0gerxdAJRC+ElvfjUjxNam3IVGB3UpN33WUDGl2vnbwA?=
 =?us-ascii?Q?qJyoop7xOYmi7hU+pbWxabkwJjtDjWsuSjrMFeqFKSEhcgduU5MAbyFlZxNK?=
 =?us-ascii?Q?c5bMNwSGVoctF+Hw826wSm89TuXxVHt8rC4gAhcolanrWDZr9ATEis0OYBV4?=
 =?us-ascii?Q?uc5XNJNcgUXfJVHwiyouUOtAMt9dHdXuHKe4Nt8r09C/S4RDcF/LzXUiwW9M?=
 =?us-ascii?Q?2CRxTQCAu8modGUWJxgBv36UJaP95W1UJRPANuaKiWuLSkIvcWrbivkvz61k?=
 =?us-ascii?Q?2N4TUpuvtej4c+nA82szc88PyMt5r2VF6iLEoRT54tsjk/K+zodxV06EY3DQ?=
 =?us-ascii?Q?LGSmSPZtuqadTlEisStGeKgICKTkBYbpdaPfzo4sTLWYUyTL8HjIuJErrrBy?=
 =?us-ascii?Q?WmIXcqZRJbYQ1gq+ERchmcdKFNt83iVBbmCrBxCA+UiB1TfWIfkQ8jkzskR7?=
 =?us-ascii?Q?epM3K70P/TC71T+pM0+ZnxE=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5f8283a-9fb6-4d10-0d13-08d9be1cd72d
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 09:42:13.0799
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qCtBsUWwPd3EUf2Vk81359UkPs+SlaNDUBfRW5x0DVFlP4xOlOd54QVqYgs3g2NQTVUTAFD44Jdt0xtSjPTZgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR06MB3179
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

Fix following coccicheck warning:
WARNING: Function "for_each_matching_node_and_match" 
should have of_node_put() before return.

Early exits from for_each_matching_node_and_match should decrement the
node reference counter.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 arch/arm/mach-at91/pm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
index 8711d68..ca313fe
--- a/arch/arm/mach-at91/pm.c
+++ b/arch/arm/mach-at91/pm.c
@@ -644,6 +644,7 @@ static __init int at91_dt_ramc(bool phy_mandatory)
 		soc_pm.data.ramc[idx] = of_iomap(np, 0);
 		if (!soc_pm.data.ramc[idx]) {
 			pr_err("unable to map ramc[%d] cpu registers\n", idx);
+			of_node_put(np);
 			ret = -ENOMEM;
 			goto unmap_ramc;
 		}
@@ -669,6 +670,7 @@ static __init int at91_dt_ramc(bool phy_mandatory)
 		soc_pm.data.ramc_phy = of_iomap(np, 0);
 		if (!soc_pm.data.ramc_phy) {
 			pr_err("unable to map ramc phy cpu registers\n");
+			of_node_put(np);
 			ret = -ENOMEM;
 			goto unmap_ramc;
 		}
-- 
2.7.4