From:   Qing Wang <wangqing@vivo.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] net: phy: add missing of_node_put before return
Date:   Mon, 13 Dec 2021 01:44:49 -0800
Message-Id: <1639388689-64038-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XkBHqAV52m5pbA9W0Q9p6e4fHzAUSQRmcCsDT3lLK02atXlqWxzymjNQLSOy?=
 =?us-ascii?Q?I6WWC8j/ylyQsCr5Mkju3sH/KLzzpuQgdYeCiWl/qma0GYq0aasCY5wvkhq5?=
 =?us-ascii?Q?3Kpy9yt3b6Vnib3zLGMD0cKoiuM+zHwfdelY0Z5HIDigRkSPXUbzfPthIikC?=
 =?us-ascii?Q?fKwMi7Z20n2shtPdXB0zaH9iCCb8H3jMMscFFW41pyIagZ2IyN24VE9AY6zu?=
 =?us-ascii?Q?RP6l2w5ozX1C++Sgf6WfpokjWmuP6S9HtjFo4+77WymolJM+41NvDyxamiya?=
 =?us-ascii?Q?l/EmDbH7HEL7O5qsLgJK5pk8KxsO/cCsP8DHYqUJifBSbnQIHR1oXpim4ppm?=
 =?us-ascii?Q?4Eopx1/rUI0jxZtv1FzGqHbb6pvtNEGRzZZnMfROVXlqDfvwTpY4llP61MZW?=
 =?us-ascii?Q?ZFOYuD/MhPHVDrP0p3LPkLfqPeEYcIQno4PZW8gKZz8fa7j97qdkkxWq3tgd?=
 =?us-ascii?Q?G5CgYjQzLGE5p7vjtiJrolTlnzN8GBEofbBJoKAhRi95jpD0caC7LB/QVxa2?=
 =?us-ascii?Q?pTNfamlyuFTTX8RM140woymwSBKOZGxGIMNq4ifSFawceJc7IK+BRylESC7J?=
 =?us-ascii?Q?UmIYxZJmqnyAQ2Etj8GxdXREAdRoLhiQ5/StKONY6YjweIweGHpGfOAoPlWk?=
 =?us-ascii?Q?LRKSB7o5Y8BhLpUymWtDeDQYNI7zi2cqGPxH8XsH6RBZzUhQibSAcoCtt13W?=
 =?us-ascii?Q?yDC+UiMtE0Gdoluihu/QwhW1IL6K3/GAjYmBHZ7l8ojLaAdibb+kjjDcYMJb?=
 =?us-ascii?Q?1zMPl4LAZbmfh+SPXPaW6PtIxAGs2yoQIZSqx2HNtyTglZ0ffnSoo1tHysbC?=
 =?us-ascii?Q?himRHkTpe7b8qJHn9aR7MU/f0BYm+ABxGUOGCqNYmvRupR/rikbf4CGzv/Nt?=
 =?us-ascii?Q?eRLea8i6554WGYLG8vPNa2OM3iSo/Jsh4VQwOLFhITn8rdgS+l8+P7x4fHY4?=
 =?us-ascii?Q?Fb6yybrmo34d8EheEhJJMV0WLXObPbQJF9dzm1qU1tESfpUcTkQyLjrUXEA5?=
 =?us-ascii?Q?+u3EUe61uiaAzG2gSY7EVicNoBYxZhtDMtrYJhthVOSVr3kspPV1kWScvFHo?=
 =?us-ascii?Q?fqipjqkubIE7ZB2740cNT6YqPXz5gvz3BEbIlB/9N1raJoQHOhjvlYlOaEMT?=
 =?us-ascii?Q?ptk0wnt2xb9aa9NTIrmQs5uT3FStCjZ4FGFkfYLP3QpN/uSZp6aqPpBmgve5?=
 =?us-ascii?Q?htdmLMcyAKkycstTX38DNYsjFzfbZzIRbnNHZ+yXEseGSpZ9vHvDYWj7DM4t?=
 =?us-ascii?Q?nRniBv800CDeosQ0piwnwcbKSWgRu+KqndJ08apl9TcGAiH+yTtAaDD2Padi?=
 =?us-ascii?Q?qIccybSq3oPi/mQm4vTo5GPiGW944hu4minGzGRldy7U0xs4Lfu1PwnI9Ahv?=
 =?us-ascii?Q?Bd4HRRNo1tfsNYmLdRqktA/i0PMIgdCXvkye2tE/1l2r/lhmRoRhe8bvGAN2?=
 =?us-ascii?Q?nJZSV/Dnwsgomzd9u//Zq9t2P+ivIPAFFqY4Uxw1iBTpV2XwxS3nMpZI7W1e?=
 =?us-ascii?Q?8BnLmWI+u5n2CIrWmKsWBj4/e3JY5poYhNIQ35oC69GeTf6nO1w6/YjGlx0o?=
 =?us-ascii?Q?UcLd0uga5/A7xvzV0MflOQf15GjNOJWc0j7jzd63pKmS80AgfXgagk2eRiL/?=
 =?us-ascii?Q?bpDLCsRjZ3PXaJDfF7AOirU=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fcf037e8-64ff-4843-317c-08d9be1d3b46
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 09:45:00.9139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BdNUoPsVCCrLSgUIPGeZsOEh9Dy94hYU44uUIO4ce3jJ6KLxavCRlKyJhNc6O5PkCNraANbTc0InhwpQOBYLxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR06MB3050
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

Fix following coccicheck warning:
WARNING: Function "for_each_available_child_of_node" 
should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/net/phy/mdio_bus.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 9b6f2df..3c5e8937
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -462,6 +462,7 @@ static void of_mdiobus_link_mdiodev(struct mii_bus *bus,
 
 		if (addr == mdiodev->addr) {
 			device_set_node(dev, of_fwnode_handle(child));
+			of_node_put(child);
 			return;
 		}
 	}
-- 
2.7.4