From:   Qing Wang <wangqing@vivo.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Gregory Clement <gregory.clement@bootlin.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] soc: dove: add missing of_node_put before break
Date:   Mon, 13 Dec 2021 01:46:09 -0800
Message-Id: <1639388769-64240-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GB7RPRO/vxOO7LQ8vEQyBbJ1a/1DjPYMmr3CIRKtZP2Ly2fNKpXCXg3PtFP1?=
 =?us-ascii?Q?4iVjJWNlf+Ktf8hqN0vdUtJK/c5lvDuwOBa0+eipnG1GhusEBNhEiS2pK0++?=
 =?us-ascii?Q?iQETeyU1sXH0EOobm0v2fzZvRs85fpiaRCPMYiJ6N3KvnUBKcCWyjuXgQkxK?=
 =?us-ascii?Q?7VtOqta8qyBJHbUssiCaX14WeViE1DoBeshGMYzZ7Z2a9zencHj5HwwL6L8O?=
 =?us-ascii?Q?QK+QHKFpMOUmC6ezhKxRLDqtquPbF4QuuVw0XOFdB4NhGdWB+CDjd+WyROEZ?=
 =?us-ascii?Q?Il4Oinh/H16V5LNhNswqbmq9Rk0uFOLev7rbPoZXHyVwhlPKAlLIo59Oj8xU?=
 =?us-ascii?Q?R5Fyyyjl13fOWpdCdeuygx2A3xhz1wCmUAMroBJtpV03AXpOq5BPJuANhJ/y?=
 =?us-ascii?Q?UPXJfmxpH5KEYvtBtFlP/y3I+g0boumVOz23XMkZSexOhHRRqNs6sShjdz4k?=
 =?us-ascii?Q?Zc7SOjDvwcmScIhf23JeiePT0EwJXK/A+FlQUfJkRpTEZ31SG5jJuuo6oNod?=
 =?us-ascii?Q?bCznEcY9KWftBmtfUh3LgDXnHpuRmnQ0aUfX8i2Fh7g53EbwG0ipq149B29B?=
 =?us-ascii?Q?ekQwl/VzB+niafGLyxfgSCbku41dSak2t0SqP67mMlV0izzVGx6gp9oRyy2+?=
 =?us-ascii?Q?qF3BMFbxcyZl8E1mje9YPDevHDZI9JvTFcaAyKcYQwlmRqTFhfL+bVsJ6XXd?=
 =?us-ascii?Q?3TlyEB7obHRCZf8EBg+pNYosDmMB0kTlEyeTE5pcVH2kPTAVZul8cJefuw1a?=
 =?us-ascii?Q?QHjNr0qIjloyBmtZzXGvwEg0vHCE2U+IKuM4Diy9Gf4HIKSgBEsuZzRx64Ly?=
 =?us-ascii?Q?HrZp1Ax+tzToSgtEfC1vMVbFwdYAgGqYvr2ByjO05ZmVwi1iFCGI8UMZt8Ol?=
 =?us-ascii?Q?0VrJVuhcvw2czFhJPzoxOMM2qpYF8kZDsRAH2rDva1TpdjfeykRRDAy96X33?=
 =?us-ascii?Q?svqYLTN5KR0Ut/SCsqzQtDaUSb6GYONAv8wufX8bMVXLieWDi/Ol44eNIZ4Z?=
 =?us-ascii?Q?+glhv9TZZcHsb3SUZSLb5gUOcscaH83EzX/TGq/d5Iw10CKTdxgQT+lviP07?=
 =?us-ascii?Q?6bXI6FajaHblb432YV5WbEcZMQe8jNFgn54jES+o8Pzbu8lpa6J71tMRM0m/?=
 =?us-ascii?Q?HigbUDtil+PkOEKmN8quUDKegGY1g9KbLe64uGF/wroAQVxjLRc9jbXjSy1e?=
 =?us-ascii?Q?2JOUINobO3F/162uHSBBNa5T3K87j0Os/A5QA6+EdQ0WVej37Jde1R47iPvA?=
 =?us-ascii?Q?XF39MkKxlUwg8CYUjh1Ky2Xntvgf/L0jkyNcMhbLjoON2SHeiOZBe8VCuIXc?=
 =?us-ascii?Q?dbJaHlZMTrCjejdyy7XdvqxvAKD8mWBrO8+F5NjUnL7DNmL38LGD+oekSpWK?=
 =?us-ascii?Q?5p+7g/8fPJl3SYzRJBMyZ36MCiexB2pqCVYFJAkhN5VoWFfemqVRrfNXdHgI?=
 =?us-ascii?Q?qVD6SAyadt+aiNIcsTraqmDoTo1NxhoWb3g+d88TIrfnm0vTQ7u79gZ9Kffi?=
 =?us-ascii?Q?/wMDEvzyEgBdkMAxwMv+MhUGSfWZiMF8Watxrfxzl+tl005mE1DmaUb6pOvs?=
 =?us-ascii?Q?jZUMW164yET3fZRPupMVA6O8hK+H1JTsNSbpL2QYleTXm2OaK9MiqJoO+tLa?=
 =?us-ascii?Q?Ufc0eAS3qAdtgtxU4kIVCCA=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68ac3152-2bfd-49a1-2e9a-08d9be1d6937
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 09:46:17.9848
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SwLlrWTUHo2PWjbPDxWdrZu1DSkRyAGULX00azae0sqQhRFRY9JAHDXH2TXmvgtN9kQSXeFuniqA4PLgFoiNmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR06MB3050
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

Fix following coccicheck warning:
WARNING: Function "for_each_available_child_of_node" 
should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/soc/dove/pmu.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
index ffc5311..6202dbc
--- a/drivers/soc/dove/pmu.c
+++ b/drivers/soc/dove/pmu.c
@@ -410,13 +410,16 @@ int __init dove_init_pmu(void)
 		struct pmu_domain *domain;
 
 		domain = kzalloc(sizeof(*domain), GFP_KERNEL);
-		if (!domain)
+		if (!domain) {
+			of_node_put(np);
 			break;
+		}
 
 		domain->pmu = pmu;
 		domain->base.name = kasprintf(GFP_KERNEL, "%pOFn", np);
 		if (!domain->base.name) {
 			kfree(domain);
+			of_node_put(np);
 			break;
 		}
 
-- 
2.7.4