Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD78C433F5 for ; Mon, 13 Dec 2021 11:27:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235691AbhLML1e (ORCPT ); Mon, 13 Dec 2021 06:27:34 -0500 Received: from mga14.intel.com ([192.55.52.115]:55980 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234729AbhLML1c (ORCPT ); Mon, 13 Dec 2021 06:27:32 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10196"; a="238937314" X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="238937314" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 03:27:32 -0800 X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="464593908" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 03:27:30 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mwjTV-005azv-Mv; Mon, 13 Dec 2021 13:26:33 +0200 Date: Mon, 13 Dec 2021 13:26:33 +0200 From: Andy Shevchenko To: Sergey Shtylyov Cc: Damien Le Moal , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede , Jens Axboe Subject: Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved Message-ID: References: <9e6b2e9a-e958-0c14-6570-135607041978@omp.ru> <6c03ffef-b2e0-16ba-35f3-206af2a611d2@gmail.com> <9d688cd8-99e3-0265-06aa-d44597e7686c@omp.ru> <448ce97b-699d-bdab-b4e9-c9439fd81a85@gmail.com> <8ec4a971-29ba-77f7-7c48-ad88decea70f@omp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ec4a971-29ba-77f7-7c48-ad88decea70f@omp.ru> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 11, 2021 at 01:13:52PM +0300, Sergey Shtylyov wrote: > On 10.12.2021 22:35, Sergei Shtylyov wrote: ... > Also, your commit log is wrong in the description of how to handle the result: > > << > Now: > ret = platform_get_irq_optional(...); > if (ret != -ENXIO) > return ret; // respect deferred probe > if (ret > 0) > ...we get an IRQ... > >> > > The (ret != -ENXIO) check also succeeds on the (positive) IRQ #s, so the > following code becomes unreachable. :-/ Indeed, thanks! Should be if (ret < 0 && ret != -ENXIO) -- With Best Regards, Andy Shevchenko