Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030256AbXAXGYz (ORCPT ); Wed, 24 Jan 2007 01:24:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030264AbXAXGYz (ORCPT ); Wed, 24 Jan 2007 01:24:55 -0500 Received: from fnoeppeil48.netpark.at ([217.175.205.176]:3651 "EHLO roarinelk.homelinux.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030256AbXAXGYw (ORCPT ); Wed, 24 Jan 2007 01:24:52 -0500 Date: Wed, 24 Jan 2007 07:24:50 +0100 From: Manuel Lauss To: Pierre Ossman Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MMC: au1xmmc R6 response support Message-ID: <20070124062450.GA6519@roarinelk.homelinux.net> References: <20070123100814.GA5001@roarinelk.homelinux.net> <45B65A73.90308@drzeus.cx> <20070124055202.GA6446@roarinelk.homelinux.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070124055202.GA6446@roarinelk.homelinux.net> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 946 Lines: 25 On Wed, Jan 24, 2007 at 06:52:02AM +0100, Manuel Lauss wrote: > On Tue, Jan 23, 2007 at 07:56:51PM +0100, Pierre Ossman wrote: > > > here's a trivial patch which adds R6 reponse support to the au1xmmc > > > driver. Fixes SD card detection / operation. > > > > > NAK. MMC_RSP_R1 and MMC_RSP_R6 have the same value so this will break > > the switch. > > not in my version of 2.6.20-rc5 (and 2.6.19): > > #define MMC_RSP_R1 (MMC_RSP_PRESENT|MMC_RSP_CRC|MMC_RSP_OPCODE) > #define MMC_RSP_R6 (MMC_RSP_PRESENT|MMC_RSP_CRC) > > Without the patch, SD card detection stops with CMD7 returning error. Correction: it fails at SD_SEND_RELATIVE_ADDR (it's the only command which request R6 response) -- ml. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/