Subject: Re: [PATCH v3] uacce: use sysfs_emit instead of sprintf
To:     <gregkh@linuxfoundation.org>,
        <linux-accelerators@lists.ozlabs.org>,
        <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
        <zhangfei.gao@linaro.org>, <wangzhou1@hisilicon.com>
References: <20211206104724.11559-1-yekai13@huawei.com>
From:   "yekai(A)" <yekai13@huawei.com>
Message-ID: <aeaa46e2-0adc-142e-f7e2-dcb4bbf8a74f@huawei.com>
Date:   Mon, 13 Dec 2021 20:05:56 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20211206104724.11559-1-yekai13@huawei.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021/12/6 18:47, Kai Ye wrote:
> Use the sysfs_emit to replace sprintf. sprintf may cause
> output defect in sysfs content, it is better to use new
> added sysfs_emit function which knows the size of the
> temporary buffer.
>
> Signed-off-by: Kai Ye <yekai13@huawei.com>
> ---
> changes v1->v2:
> 	modfiy the comments.
> changes v2->v3:
> 	modify the "changes" lines.
>
>  drivers/misc/uacce/uacce.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
> index 488eeb2811ae..281c54003edc 100644
> --- a/drivers/misc/uacce/uacce.c
> +++ b/drivers/misc/uacce/uacce.c
> @@ -289,7 +289,7 @@ static ssize_t api_show(struct device *dev,
>  {
>  	struct uacce_device *uacce = to_uacce_device(dev);
>
> -	return sprintf(buf, "%s\n", uacce->api_ver);
> +	return sysfs_emit(buf, "%s\n", uacce->api_ver);
>  }
>
>  static ssize_t flags_show(struct device *dev,
> @@ -297,7 +297,7 @@ static ssize_t flags_show(struct device *dev,
>  {
>  	struct uacce_device *uacce = to_uacce_device(dev);
>
> -	return sprintf(buf, "%u\n", uacce->flags);
> +	return sysfs_emit(buf, "%u\n", uacce->flags);
>  }
>
>  static ssize_t available_instances_show(struct device *dev,
> @@ -309,7 +309,7 @@ static ssize_t available_instances_show(struct device *dev,
>  	if (!uacce->ops->get_available_instances)
>  		return -ENODEV;
>
> -	return sprintf(buf, "%d\n",
> +	return sysfs_emit(buf, "%d\n",
>  		       uacce->ops->get_available_instances(uacce));
>  }
>
> @@ -318,7 +318,7 @@ static ssize_t algorithms_show(struct device *dev,
>  {
>  	struct uacce_device *uacce = to_uacce_device(dev);
>
> -	return sprintf(buf, "%s\n", uacce->algs);
> +	return sysfs_emit(buf, "%s\n", uacce->algs);
>  }
>
>  static ssize_t region_mmio_size_show(struct device *dev,
> @@ -326,7 +326,7 @@ static ssize_t region_mmio_size_show(struct device *dev,
>  {
>  	struct uacce_device *uacce = to_uacce_device(dev);
>
> -	return sprintf(buf, "%lu\n",
> +	return sysfs_emit(buf, "%lu\n",
>  		       uacce->qf_pg_num[UACCE_QFRT_MMIO] << PAGE_SHIFT);
>  }
>
> @@ -335,7 +335,7 @@ static ssize_t region_dus_size_show(struct device *dev,
>  {
>  	struct uacce_device *uacce = to_uacce_device(dev);
>
> -	return sprintf(buf, "%lu\n",
> +	return sysfs_emit(buf, "%lu\n",
>  		       uacce->qf_pg_num[UACCE_QFRT_DUS] << PAGE_SHIFT);
>  }
>
>

Hi Hartman

Could you help to take this patch?
Thanks.

Kai