Message-ID: <97eb3c3f68042443aa71c10766f3bef364e8f90b.camel@perches.com>
Subject: Re: [PATCH v20] tty: Fix the keyboard led light display problem
From:   Joe Perches <joe@perches.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        lianzhi chang <changlianzhi@uniontech.com>
Cc:     linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org, 282827961@qq.com,
        kernel test robot <lkp@intel.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
Date:   Mon, 13 Dec 2021 04:41:24 -0800
In-Reply-To: <Ybc5XPfd5f66L92i@smile.fi.intel.com>
References: <20211213061244.13732-1-changlianzhi@uniontech.com>
         <Ybc5XPfd5f66L92i@smile.fi.intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-12-13 at 14:15 +0200, Andy Shevchenko wrote:
> On Mon, Dec 13, 2021 at 02:12:44PM +0800, lianzhi chang wrote:

> > +	struct kbd_struct *kb = &kbd_table[console];
> > +	int ret = 0;
> > +	unsigned long flags;
> 
> Slightly better to read:
> 
> 	struct kbd_struct *kb = &kbd_table[console];
> 	unsigned long flags;
> 	int ret = 0;

I don't think so.  Why do you?