Date:   Mon, 13 Dec 2021 21:14:47 +0800
From:   Peter Chen <peter.chen@kernel.org>
To:     Pawel Laszczak <pawell@cadence.com>
Cc:     gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] usb: cdnsp: Fix issue in cdnsp_log_ep trace event
Message-ID: <20211213131447.GC5346@Peter>
References: <20211213050609.22640-1-pawell@gli-login.cadence.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211213050609.22640-1-pawell@gli-login.cadence.com>
Precedence: bulk

On 21-12-13 06:06:09, Pawel Laszczak wrote:
> From: Pawel Laszczak <pawell@cadence.com>
> 
> Patch fixes incorrect order of __entry->stream_id and __entry->state
> parameters in TP_printk macro.
> 
> Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
> cc: <stable@vger.kernel.org>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
>  drivers/usb/cdns3/cdnsp-trace.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/cdnsp-trace.h b/drivers/usb/cdns3/cdnsp-trace.h
> index 5aa88ca012de..13091df9934c 100644
> --- a/drivers/usb/cdns3/cdnsp-trace.h
> +++ b/drivers/usb/cdns3/cdnsp-trace.h
> @@ -57,9 +57,9 @@ DECLARE_EVENT_CLASS(cdnsp_log_ep,
>  		__entry->first_prime_det = pep->stream_info.first_prime_det;
>  		__entry->drbls_count = pep->stream_info.drbls_count;
>  	),
> -	TP_printk("%s: SID: %08x ep state: %x stream: enabled: %d num  %d "
> +	TP_printk("%s: SID: %08x, ep state: %x, stream: enabled: %d num %d "
>  		  "tds %d, first prime: %d drbls %d",
> -		  __get_str(name), __entry->state, __entry->stream_id,
> +		  __get_str(name), __entry->stream_id, __entry->state,
>  		  __entry->enabled, __entry->num_streams, __entry->td_count,
>  		  __entry->first_prime_det, __entry->drbls_count)
>  );
> -- 

Reviewed-by: Peter Chen <peter.chen@kernel.org>

-- 

Thanks,
Peter Chen