Date:   Mon, 13 Dec 2021 16:20:53 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     lianzhi chang <changlianzhi@uniontech.com>
Cc:     linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        andriy.shevchenko@linux.intel.com, 282827961@qq.com,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v20] tty: Fix the keyboard led light display problem
Message-ID: <20211213132053.GW1978@kadam>
References: <20211213061244.13732-1-changlianzhi@uniontech.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211213061244.13732-1-changlianzhi@uniontech.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TS7hf2BnymdNTGtkakrCip/mDT/gAlY0xDpRrOWLLQ07IsdThmVRG9+vMx7q?=
 =?us-ascii?Q?G8RqE33A5sjVqokpUf54374872uANPsClxAqtJAx8zAPN+kCWrmdj6wm3ZDy?=
 =?us-ascii?Q?wwNynkGfdCMKUKR5bolFgOQ5I2Ysm1lxF6V+2u3qa46HYSNfRTGUNR7IpiBe?=
 =?us-ascii?Q?n0UHWDbwDXrFb+UpVAe8i3L+Kw+KfB+GkJVAJ73UnPQ209aSZKkmV6DUjn6y?=
 =?us-ascii?Q?zA0if95rel+3wAm2wl4kkeaecbZ7zt2cy5UBv63gGsY5fT4+wVUJO/0WTJsb?=
 =?us-ascii?Q?52Zly/ZhqdqiRdaNy5uE31qmamXk815W2XZXTp0byP9sqY585dFjDRe/cqIt?=
 =?us-ascii?Q?+CUbR0Rf5ye+sAXWdWiHSIAphI0tv713iaEofvp/06qBpStdm97eUrVn+DNn?=
 =?us-ascii?Q?QaajfJBfZINmt0U2vK1wldZ7UGQSasXyP9gwpHoAmfveO249kMKZ5TV49jb4?=
 =?us-ascii?Q?Dj2t9xtNo/2fIqcqfDpO7aZDiLP7F6iInbNOG/WMlj7bW2l5GcSMTHh1Omy9?=
 =?us-ascii?Q?+KXCeCD/hYnB8si1jOUWWGj1xKqoLI0nJYfeu82+vefmkDxWojkpRFtT2sNE?=
 =?us-ascii?Q?FvJV2iNOafhyEqHKUuXAobO6oqTl5Kbh2x34QRWWHj4l8TL/S+xkz6tuy9cd?=
 =?us-ascii?Q?g6tQRBXNGXDo+7RpkAkYetSYoLHaUDVTKiBEPzdoHIc2NZbZyj2nUh1qI6NS?=
 =?us-ascii?Q?JvvvjgvQt6v1Tvw971PJG8KGFYZvllldeYuq06lVXrZy0t4YB2KV2XXHNgOL?=
 =?us-ascii?Q?RzamnHhpVGFzI2ofWYOFdqvon5c/UcYZCkmNQAEPniepxvBvxa9L3nPH617C?=
 =?us-ascii?Q?nqGlNTh5vCB2SGJ2dEjq7Ts08Iqult3q2PW9AtuxTCjE26+1nkLC4k9EM4VI?=
 =?us-ascii?Q?f83FYred4WDIjeKH2oB5hA3zQv5voj35XRDW9pNT6k5+MJ4Rb1EALo0AD875?=
 =?us-ascii?Q?bHJBi9dnUZWgYcj7HycaNv6YfeAg6x9d26fw1/hWf8V01LdpajOKR8H9ToEx?=
 =?us-ascii?Q?lx+vMwPzhJz4woyJ0InSfcgHN1x3x3mpRoc5ZU/qI8ztAfnD54NeKaobFTGQ?=
 =?us-ascii?Q?oHKT0ZvlT/D+6NAB7nk+tlZBgqo7ohVJA2UduPJUR2tjckViLwzfVhZKFwe1?=
 =?us-ascii?Q?87Rrv31kicoU+SqhTyy5ETlwrts5HPDSvqXdlgT4lMcaBvjiC5Y0UbTlzxKr?=
 =?us-ascii?Q?LQIau/Z2ZEdIa+r7r/I8hJeGa9Xx3G65KqF+mlo2nJ5F6rIaJSY7hZdRAoSJ?=
 =?us-ascii?Q?03YYK5jJ6dKH7G1i0DZnnlrHgMcSFsd/DLRmX6g3lAOADuSpV1VwS+l/uuDW?=
 =?us-ascii?Q?KQXtKXhz9ea4dYOuzmXLEmoYa23rvbi/uNe6qSB345hEZNOuwMHRtGm78piK?=
 =?us-ascii?Q?pHDGbvDJtdnsBhvnGEAkLlBodp3RsFL+QgBASUhsji6AXBNycgqY4QHLZmrq?=
 =?us-ascii?Q?HWNTIq7zzJ9V7JQaXkt88vyLRzN9/2pn9VS83Qn/Kk8YHib32Pg6NY0lG41K?=
 =?us-ascii?Q?Oudr7IIF8X5W3TxCH1QuR39qzR3pn/pqvQvsLz7wVKcURvf33qrpLmVVpVr4?=
 =?us-ascii?Q?Hjt++PBYQycMHfe8JwclNoGhnvd5V215C0u+i6uXVnnjlq4vWMlQQy6d6zg0?=
 =?us-ascii?Q?bxNqkya3bRFeLEVunONhWJUerLK3d9Edpnw/ad1idN0OSY92vxPVf4+WYCCg?=
 =?us-ascii?Q?JR5Isw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 117b1e92-666a-40a7-7471-08d9be3b706b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 13:21:15.0322
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rtEDX6gm2vrXYQjCIiu7Ti3toRPufoApf9n3bIsfWGmVywoiWvZ43GKbHUJC72EW/SzHtUvSEzkkFNU82/dgUmZr55RIKzJzhaI4Wba+1kQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5789
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10196 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112130085
X-Proofpoint-GUID: oMyStP4iBhivnM0qAUaA_4fEJdXqieWD
X-Proofpoint-ORIG-GUID: oMyStP4iBhivnM0qAUaA_4fEJdXqieWD
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

"the keyboard led light display problem" is pretty vague.  Perhaps say
"Fix incorrect "Num Lock" LED indicator"

On Mon, Dec 13, 2021 at 02:12:44PM +0800, lianzhi chang wrote:
> Use the "ctrl+alt+Fn" key combination to switch the system from tty to
> desktop or switch the system from desktop to tty. After the switch is
> completed, it is found that the state of the keyboard lock is

Is this one of those fancy gaming keyboards with LEDs under the keys or
are we talking about Num Lock?


> +int vt_do_kdgkbledctl(unsigned int console)
> +{
> +	struct kbd_struct *kb = &kbd_table[console];
> +	/* This is a spot read so needs no locking */
> +	switch (kb->kbdledctl) {
> +	case VC_LEDCTL_ON:
> +		return K_LEDCTL_ON;
> +	case VC_LEDCTL_OFF:
> +		return K_LEDCTL_OFF;
> +		}

Extra tab.

> +}
> +

> +#define VC_LEDCTL_ON  0	/* VT can set the keyboard light */
> +#define VC_LEDCTL_OFF 1	/* Prohibit VT to set the keyboard light */

> +#define K_LEDCTL_ON 0x00
> +#define K_LEDCTL_OFF 0x01

It's weird that ON is zero and OFF one.  Really, it's unfortunate that
we need a new ioctl to fix this bug...

regards,
dan carpenter