IronPort-SDR: gTe6a5I4MRYftmZ5IrnyQFVkAtM1sgTASsKfz6qqDZ+HIPDsViTXxzxhgbZvmkSeZSU1AlreEC
 kDTxeOtTWZOIW0qQa1D9ewXJELnL2354Co5vVElL+Q8clP74FJmTtqvgL0i3aR+Y/LCuTnBWmC
 GN8FVzb6oiv9RR7qPjormKUuJFKfhiUwbtyhQKTN26hnn1RLYmfTVSh84XWSL+NOayAEf8TXR2
 6Pb640kVwBiYhHchSl7ZcpJxNfSBi+PMLeityHq7Aot1lQIe3gwhYDnaCJTZvgk0J7sN15eQO+
 JxeRJeLQKXtzZr7ujslxovOU
Subject: Re: [PATCH] arm: mach-at91: add missing of_node_put
To:     Qing Wang <wangqing@vivo.com>,
        Russell King <linux@armlinux.org.uk>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Ludovic Desroches <ludovic.desroches@microchip.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <1639388520-63567-1-git-send-email-wangqing@vivo.com>
From:   Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
Message-ID: <d2cae713-0985-eb98-10a3-c1b26ee74fe7@microchip.com>
Date:   Mon, 13 Dec 2021 14:34:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <1639388520-63567-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13/12/2021 at 10:41, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
> 
> Fix following coccicheck warning:
> WARNING: Function "for_each_matching_node_and_match"
> should have of_node_put() before return.
> 
> Early exits from for_each_matching_node_and_match should decrement the
> node reference counter.
> 
> Signed-off-by: Wang Qing <wangqing@vivo.com>

Wang,

What's the difference between this patch and the one accepted here:
https://lore.kernel.org/all/20211014084555.21422-1-wanjiabing@vivo.com/

Regards,
   Nicolas

> ---
>   arch/arm/mach-at91/pm.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index 8711d68..ca313fe
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -644,6 +644,7 @@ static __init int at91_dt_ramc(bool phy_mandatory)
>                  soc_pm.data.ramc[idx] = of_iomap(np, 0);
>                  if (!soc_pm.data.ramc[idx]) {
>                          pr_err("unable to map ramc[%d] cpu registers\n", idx);
> +                       of_node_put(np);
>                          ret = -ENOMEM;
>                          goto unmap_ramc;
>                  }
> @@ -669,6 +670,7 @@ static __init int at91_dt_ramc(bool phy_mandatory)
>                  soc_pm.data.ramc_phy = of_iomap(np, 0);
>                  if (!soc_pm.data.ramc_phy) {
>                          pr_err("unable to map ramc phy cpu registers\n");
> +                       of_node_put(np);
>                          ret = -ENOMEM;
>                          goto unmap_ramc;
>                  }
> --
> 2.7.4
> 


-- 
Nicolas Ferre