Date:   Mon, 13 Dec 2021 09:37:35 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Megha Dey <megha.dey@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
        Cedric Le Goater <clg@kaod.org>,
        Juergen Gross <jgross@suse.com>,
        xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        linuxppc-dev@lists.ozlabs.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org,
        Mark Rutland <mark.rutland@arm.com>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Joerg Roedel <joro@8bytes.org>,
        iommu@lists.linux-foundation.org,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Peter Ujfalusi <peter.ujfalusi@gmail.com>,
        Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 01/35] PCI/MSI: Set pci_dev::msi[x]_enabled early
Message-ID: <20211213133735.GU6385@nvidia.com>
References: <20211210221642.869015045@linutronix.de>
 <20211210221813.250049810@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221813.250049810@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xdqpvC6oG/g8YjIodR1SC4/6w3DBlwnZJ0pJ5J+9kjCrBJbjmPTloLXFgSWU?=
 =?us-ascii?Q?XTyGOe4aUI29ZZb2KP2+F3Sh9pNDeSADj3XDjmgU3H1PJK8nCcq62n337HBg?=
 =?us-ascii?Q?WVwhCHVZQh51MA1uZ4llaE0WsHXusAe/NpQ0+aQItmefcLUpeJmNHcQ1uVJ/?=
 =?us-ascii?Q?4+7wiFaIh4xyAjp2rpvQj9RodEKiGmwQHDggzJfkqqMFgaX+rI05mcJs/NRc?=
 =?us-ascii?Q?h/St0MWkgpHbX0lkTGw7BUINrpXkhV82undeRCyAW9Mjxhj0RoBj01CZedwv?=
 =?us-ascii?Q?+t2BkL5FcXzFN/nI8wFJfYz+hf9+wWKstPUD089HvAxxcnBKctmp9d7kx551?=
 =?us-ascii?Q?f48DK4/sxFzAkm7QXHvMZ3V3g+33FGbd2fk5jTGFXMr4sdqDEUQW5OzNnNaT?=
 =?us-ascii?Q?r3ianOYaF10GTHCoSbFbFJe7BM0unNiP5IKcYjY5k3r1hiIwelOhi3TqETR3?=
 =?us-ascii?Q?3WP+CaTRaQqpV1rZ/ICh7M56q5w7HC9cLvq2PMJ6hAOCcSEY5acqLz6UtH5c?=
 =?us-ascii?Q?YdXwSKE/oSkd/BN8tnNQsohn3rFthwg+4WCedpXhfY5ZpkwmIk4aJuQIwlqh?=
 =?us-ascii?Q?Y0XZBVP3NVhMEnvMc2GYlm0VF246sGlXHKPFHGGGjEum41Zosyhv/pGsuUD9?=
 =?us-ascii?Q?TbelPO+G2Myz8I98fbyTJO+buyH9jxmmgJR0HrWtRjsLxujZO7JOZ/k3djW5?=
 =?us-ascii?Q?iGb0shFdBAQB8ij/bGpNMEwV9vgT99DskvE5jp6hI+xIH9gxHTj4tMD0qceC?=
 =?us-ascii?Q?VPBguO27ihBmUSFT7KGPZf0A+cUtvzz7bo6d5NMhkJHgXSOCIgfF46jf2Q1I?=
 =?us-ascii?Q?KD9SDpdczWJqDk0sqXY7PZEMDLV/jNVfWrW2YN3uVqGIb5oyMgL8UQ2ZW8Eq?=
 =?us-ascii?Q?RN/+Ac/gQ3z0pl/3FtdIbjXa7v499FzyZQXD6F3XRhbI8TYSK6Sx/a2Bkff3?=
 =?us-ascii?Q?ATQkvEzUPcU13I21IvWl5YE9ZdxHJfnJ3kiZMRqtsqJAIfyro8MIdiMewviH?=
 =?us-ascii?Q?HbDF0eWilAPXOEohUbSUlDoZdrBokj9EKaQdy3sVLrgm/8CnXkAIK1+ZYEmM?=
 =?us-ascii?Q?Dg/qJvd403zZojUiF8yTilXG+aReBDrJMFF0SgmW5IIXyP5MgWN5/T9lpeHN?=
 =?us-ascii?Q?SdNMYIo6n7b4mUF20CfBfVTWWe2z8AaP0qPNRWXe5nOfJGpAQXIzA4fXyZdT?=
 =?us-ascii?Q?74dlnPeVgUC4fP20/lwkM9Pi6eAdar/z2ngarMQ1JOVN2P9LWBEeQ98JLfSg?=
 =?us-ascii?Q?8VdoKOfoopHxnEq10zr5ZH4yjrMKRuic+EVMCjAI19e+2oReOwupEXKKCcx5?=
 =?us-ascii?Q?3CATr5MC0B2E7gSMjzIBczFwGftt99cyP4/o0N1f+9fPYlGRyqS9bXa6DMn2?=
 =?us-ascii?Q?7qBYoIv0rbk5kMvn89z8xAat/3eDb1Cscrl7yNZLCZnOfDZsILYYQDT03gUu?=
 =?us-ascii?Q?DQHY/K2u+hvbI5xkFE4ItRbbN9ofh6jMhrcOkugbPso8ntAqtVF7SOq9FhNR?=
 =?us-ascii?Q?E1RXBy+DpRjwV+b/Ot++hGmUoZr2mobxa3J7lGRd7YSvQzTMZGLdKV2/f34d?=
 =?us-ascii?Q?0EnIyilE+lYn1/BDh/Y=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f276fb4-b3b7-4cd0-30db-08d9be3dba1f
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 13:37:37.6399
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VytknH7paVPjrCWIKp0flqHqBuCf5kFFsxuZNo9G/pTnt4rie8xiU6i3m/jhM/Nc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5207
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 10, 2021 at 11:18:44PM +0100, Thomas Gleixner wrote:
> There are quite some places which retrieve the first MSI descriptor to
> evaluate whether the setup is for MSI or MSI-X. That's required because
> pci_dev::msi[x]_enabled is only set when the setup completed successfully.
> 
> There is no real reason why msi[x]_enabled can't be set at the beginning of
> the setup sequence and cleared in case of a failure.
> 
> Implement that so the MSI descriptor evaluations can be converted to simple
> property queries.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> V3: New patch
> ---
>  drivers/pci/msi/msi.c |   23 +++++++++++++++++------
>  1 file changed, 17 insertions(+), 6 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason