Message-ID: <c59fa2ee-f22e-eff6-8a4e-0f8ac3981f07@oracle.com>
Date:   Mon, 13 Dec 2021 08:46:31 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/gntdev: fix unmap notification order
Content-Language: en-US
To:     Oleksandr Andrushchenko <andr2000@gmail.com>,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc:     jgross@suse.com, sstabellini@kernel.org,
        Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
        stable@vger.kernel.org
References: <20211210092817.580718-1-andr2000@gmail.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211210092817.580718-1-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlJYMjhlUHN2d29UQXFobytpb3F1REVESm5lbk1jUFB2cU8zWkE1TjU2ZzdU?=
 =?utf-8?B?aEhsR0VmbkVrSkpwbUh2ZlhGb3dEUEFmR3lmcjVaTWdHSjB4RXpnck82NTMx?=
 =?utf-8?B?TVpUUG5ranhqNnoyWVBRNzBCR3pmcDZIL0JzeHdqa1VBRE1VVkRmZUZEYXYx?=
 =?utf-8?B?c3lxUFFnRjJLU2VkcSs1QXh0ZXQ2eTkvR3hrMm91OGd3VVl6R1pRSm80ZkNL?=
 =?utf-8?B?aEFMamVwUmhieWtkVjJBUVROMVFOUTMzZ2tndkxUTmRzeDNMaXIzajhEMXJu?=
 =?utf-8?B?R0c3UWt4VVpPMnlISDZ6aHdlV3dtc1VWZlkxYzRaQ0xQNVdCazlrYlY5UnBB?=
 =?utf-8?B?S3J0b1ZlUzdCNE5FVmJhYVFVYVdDOStlU2tHOVpWYlpTUU9iZHpYalgvcmJO?=
 =?utf-8?B?VFlXUmFnbTYyT1ZFblZJRGt3WjRKSWJwSGFIYWNCUFJPaVlRVjlhM0lub3Vm?=
 =?utf-8?B?UVVUaFlwTHVnQUJXNXYxVFBkODZ0M3Nod3BDdFo2enNWYUNLZmU2UEZzUE5k?=
 =?utf-8?B?OWRiWXpzNFRZRWpnYk5jbHNzek0zZUZCdjArWTBiUWdpTHc1Yzl4TUI4N2VC?=
 =?utf-8?B?eHJmY3ZsSkpwSEZwN1gxOGZtT3A3Z0xralBQV1oybVZ2Q1JSNUxOL2J6ZmRk?=
 =?utf-8?B?RjJyRENCNEtvYzE5U3grNnJVQi91SG1ta3I3MTJ2MXpJVE0wT3hqVE1aRnRa?=
 =?utf-8?B?TUhlbDNsVmJaa1l5VmZBOGdYQ2FFbHRPOEdiZEU0WHZReFBsZiszSUxHVkFq?=
 =?utf-8?B?UmpsalYvdE14cTFCNFFXNzVQZDljejZXbUJSaHVsYTVEMEl2OWN3ZnNyVlB4?=
 =?utf-8?B?dDhZTDZZZXpIVk9aZ0lCSHdpQXBQS0UyNG0zUG5oTlYzRWMyeURERzJQT2JX?=
 =?utf-8?B?cjA5T1cyZTROTmljYnlqVlh1OTIyQ1dhV0NmMndYVitGakZGVjhkRmRBT21O?=
 =?utf-8?B?Y2tiOEJxOFZkNVZHZUE5aGIwZ1NyTTBVdWU5dVNVRFg1L3p0OTZoaTZhOGFJ?=
 =?utf-8?B?WU0rOVhZNEU3Qks1UXQxT0VRbGRMY2IrS2NYMHcyRmV6Qkc4bHBUMlBkSHlU?=
 =?utf-8?B?V0VYQXE2WktMQ0hveXhHUEF3TWYvWllsYTFURk91bU9QaFZKNHQzK045LzRx?=
 =?utf-8?B?dUJqclVsd1A2Uko3UmFaaHhiMVd5VzdoekVxb3I4M3NGRmd6cDlxMmdEaFJV?=
 =?utf-8?B?SzJKZ2NNREcyNUwvQkVCNU5NczVaOFNnLzYxZmU1dE94Ti9JRSthRUF0TXhD?=
 =?utf-8?B?eDIzTHQwNkdXVWtLZFFUbDY5d2M1ZTR6TE9IbEw3ZDVJTHZUc0NKRlJtTUR3?=
 =?utf-8?B?bHkzRmJtNlRIbVFpZ0RqekZadGovcTZOMnZ4Yk1JUDlJRER2a0wxL2NSeFdR?=
 =?utf-8?B?aDE2N2tJUlRMUFVmcFZadWpCQU9KT0FhMElUUklLYUhnOXZLa2w4QXNDc2hX?=
 =?utf-8?B?dTlidkszR1ZQMitab05ib1lCTGhDWDhmRVc3U2tNOGs0NXJoTnpCaEpDc0Y4?=
 =?utf-8?B?RFNCbmFlRG9PWmJEUkdvb0tiK1hCd2gxOTh2MXh5L1MxYzNXT2crSXNOOEZB?=
 =?utf-8?B?bkx3QVV4bll1Yi9HTjRZdHFNTHpnRDljTFRxS3JWZmFJYnNnall0RUtuQ0lx?=
 =?utf-8?B?YTlsRHZHd2Npb0Q0UVRTUG9qa1J2ekFXblVsRlhvTWczOVV4SU5objBVMnFS?=
 =?utf-8?B?dkZTMEZSTVdzd2RGVVVFQzdvaU94OHFTMzZPdXQ1Z1hrOHdmRmd2SlRiWEZw?=
 =?utf-8?B?dmtkRjdjVDZYYS9vTElEWSs5NW1DbFFjZGJzencxOFoyaVRCazNhMlBCZFhh?=
 =?utf-8?B?REQwZlBOVS9hRGFRMmhJd2hieVZnc09Wcjl0M0pZdGo5c3R5aWQrM1ZhZjBD?=
 =?utf-8?B?UWFUeVN5RUYxU2p6bjBKUytYQ21RSS80OHkrUFUzSjYxRVpSdUN5UURVQXZT?=
 =?utf-8?B?R0NwcUVhOXVyRkpEemJVNWpUQ0dieGJ1MEQzeGlRY2wwQ3ZFM1A4UFNLS3U1?=
 =?utf-8?B?WXpGK21GMDIyaHp4dGJnS0tiemQvRUx3dXp0UG9pNVErb2Fpb01zYnhWVkNt?=
 =?utf-8?B?ejJscm9XUGZzcGlRVUZvMEc4S1IvR2Z0OXpHMzhTczg3V2VvSkxjVVE2WUNG?=
 =?utf-8?B?bGNQMWJzVmdDNS9vTkZqcGJoQlByMFNOQ0xuM2dHSkVqMGp0MDllZHJXV3VK?=
 =?utf-8?B?bVpFbUN1bER2OGFSdWpiVFlIbXJkWFVZZDdQZms5eUJoL0ZPZjhMVTlwSjRV?=
 =?utf-8?B?dG9mR09xZ0NRY3VSd3Y0bFIrZEtBPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d178a71e-a388-45ae-7ada-08d9be3efb79
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 13:46:36.7680
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bngYBodl0HZeuw984MCyTqmH/Be8PdJ6GlFFMjsy/7wke280LpuPTXa1K+BPyDQBTeXSOVm8Rmj8I1lWlsZazLMKo2yxvcUr9cf/e6d8iOU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2785
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10196 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112130087
X-Proofpoint-GUID: 1SbUEeN1LtsQLUajcInKZNXiYA30yCZr
X-Proofpoint-ORIG-GUID: 1SbUEeN1LtsQLUajcInKZNXiYA30yCZr
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/10/21 4:28 AM, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> While working with Xen's libxenvchan library I have faced an issue with
> unmap notifications sent in wrong order if both UNMAP_NOTIFY_SEND_EVENT
> and UNMAP_NOTIFY_CLEAR_BYTE were requested: first we send an event channel
> notification and then clear the notification byte which renders in the below
> inconsistency (cli_live is the byte which was requested to be cleared on unmap):
>
> [  444.514243] gntdev_put_map UNMAP_NOTIFY_SEND_EVENT map->notify.event 6
> libxenvchan_is_open cli_live 1
> [  444.515239] __unmap_grant_pages UNMAP_NOTIFY_CLEAR_BYTE at 14
>
> Thus it is not possible to reliably implement the checks like
> - wait for the notification (UNMAP_NOTIFY_SEND_EVENT)
> - check the variable (UNMAP_NOTIFY_CLEAR_BYTE)
> because it is possible that the variable gets checked before it is cleared
> by the kernel.
>
> To fix that we need to re-order the notifications, so the variable is first
> gets cleared and then the event channel notification is sent.
> With this fix I can see the correct order of execution:
>
> [   54.522611] __unmap_grant_pages UNMAP_NOTIFY_CLEAR_BYTE at 14
> [   54.537966] gntdev_put_map UNMAP_NOTIFY_SEND_EVENT map->notify.event 6
> libxenvchan_is_open cli_live 0
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>


Applied to for-linus-5.16c


-boris