Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CD05C433EF for ; Mon, 13 Dec 2021 13:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238021AbhLMNvM (ORCPT ); Mon, 13 Dec 2021 08:51:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238028AbhLMNvK (ORCPT ); Mon, 13 Dec 2021 08:51:10 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81C0AC061748 for ; Mon, 13 Dec 2021 05:51:09 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id y13so51879486edd.13 for ; Mon, 13 Dec 2021 05:51:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JA6W9bf1908WD6cfFb6AhPYhGreRD1L3ZPU1ovM0YAo=; b=JR+DaCc5q3x/nJ52dLl6r+4FwSEv9WD0p7h6CAvJzuCN4LA6+wkAYifxMiKmhtGPMC FTN/0x8gYKn6C0DH+DPrgH6lH2w+WJEIfGDy1/YzVD0zU202RDccLQt46z8yx/mv5SEQ orFijgywNSCXDOJ/OPyq3mvh5NlrdflBnU+13ax6fE2dt0FQGfzQsQKPQMlWf12X6gYS H/d+nrvTinlxhp9IzxuZ3LhRXaM+23FWY9lMgayxh0hvEqluoQhfJStRiFE2+rfIOnQF Iw8LA3Ko152lC8tyud5LtFSKXRrJ7LmTPR7MzT1Pb8/drF5Zj0ygRhSQOmk3y0qr4lHt 19ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JA6W9bf1908WD6cfFb6AhPYhGreRD1L3ZPU1ovM0YAo=; b=aLoNxLxBcWBD73B4AQvi6JtB2wEonM0S2m4fl/LiRfF7iqjhCKLEA5BMJ+OijBdKEw +S5nwtOaNbTvIbGWCJriQtKg88WmgdAt68fBmJRyHjduzzfXWtv1Sc16eIPzVLMd/Rl0 ajp5AIWZcm4VQ3k2BIpWr2IYhi8SevV5urRYYzUPrMSxz+i6/1bEYMwYIk1g8D9ojsxW tReG+9eoLq5EX0okdySzHDHOZZgK9Eh1bMA+9Gqohe3fZWd07gmTGJd0az42JYKQe/Mf 9DeRnPK/5ZBd7mLCeJXTDTUaq16/OqaWn4T41Au0UbQE3rrdXosKLmCe1hxxMTMbUKqE BWDw== X-Gm-Message-State: AOAM532IGk4WL199+xr0VttJjsN9Xw+yrcO+a5jGNyuqbHoZvpyzWuYQ pKDmSGm7ClfUPZkfbTs+FeTVO9v+N0Ks72awm05uBg== X-Google-Smtp-Source: ABdhPJyUfRonKaOMYp5CA3+4Qguk6GD9f9+ENkQJ7XEThNqMIaIY/ZVhde1IxmgVdguaMtUOm8hj/b6kBh4NcjdyhEI= X-Received: by 2002:a05:6402:354e:: with SMTP id f14mr63951085edd.245.1639403467922; Mon, 13 Dec 2021 05:51:07 -0800 (PST) MIME-Version: 1.0 References: <20211202210839.79140-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20211202210839.79140-1-andriy.shevchenko@linux.intel.com> From: Bartosz Golaszewski Date: Mon, 13 Dec 2021 14:50:57 +0100 Message-ID: Subject: Re: [PATCH v1 1/3] gpio: Get rid of duplicate of_node assignment in the drivers To: Andy Shevchenko Cc: Marc Zyngier , Matti Vaittinen , Sergio Paracuellos , Chunyan Zhang , Baruch Siach , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Tony Lindgren , Nicolas Saenz Julienne , Linus Walleij , Jianqun Xu , Alexandru Ardelean , Thierry Reding , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , patches@opensource.cirrus.com, bcm-kernel-feedback-list , linux-power , Linux ARM , "moderated list:ARM/Mediatek SoC..." , "open list:PWM SUBSYSTEM" , Linux-OMAP , linux-unisoc@lists.infradead.org, "open list:ARM/Rockchip SoC..." , linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, Ray Jui , Florian Fainelli , Scott Branden , Gregory Fong , Eugeniy Paltsev , Keerthy , Orson Zhai , Baolin Wang , Chunyan Zhang , Vladimir Zapolskiy , Matthias Brugger , Thierry Reding , Lee Jones , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Robert Jarzmik , Manivannan Sadhasivam , Heiko Stuebner , Ludovic Desroches , Maxime Coquelin , Alexandre Torgue , Jonathan Hunter Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 2, 2021 at 10:17 PM Andy Shevchenko wrote: > > GPIO library does copy the of_node from the parent device of > the GPIO chip, there is no need to repeat this in the individual > drivers. Remove these assignment all at once. > > For the details one may look into the of_gpio_dev_init() implementation. > > Signed-off-by: Andy Shevchenko > --- If there are no objections, I am willing to apply this to give it some time in next and get the work on dropping the OF APIs from gpiolib going. Bart