Date:   Mon, 13 Dec 2021 15:09:51 +0100
From:   Greg KH <greg@kroah.com>
To:     Xiaoke Wang <xkernel.wang@foxmail.com>
Cc:     andreas.noever@gmail.com, michael.jamet@intel.com,
        mika.westerberg@linux.intel.com, YehezkelShB@gmail.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: check the return value of kmemdup()
Message-ID: <YbdULyzjOq0hUi8Q@kroah.com>
References: <tencent_8268B88CD2F7BF04083AF35D6E2C87158506@qq.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tencent_8268B88CD2F7BF04083AF35D6E2C87158506@qq.com>
Precedence: bulk

On Mon, Dec 13, 2021 at 04:27:15PM +0800, Xiaoke Wang wrote:
> Note: Compare with the last email, this one is using my full name.
> kmemdup() return NULL when some internal memory errors happen, it is
> better to check the return value of it. Otherwise, some memory errors
> will not be catched in time and may further result in wrong memory
> access.
> 
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
>  drivers/thunderbolt/icm.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
> index 6255f1e..fff0c74 100644
> --- a/drivers/thunderbolt/icm.c
> +++ b/drivers/thunderbolt/icm.c
> @@ -1741,8 +1741,13 @@ static void icm_handle_event(struct tb *tb, enum tb_cfg_pkg_type type,
>  	if (!n)
>  		return;
>  
> -	INIT_WORK(&n->work, icm_handle_notification);
>  	n->pkg = kmemdup(buf, size, GFP_KERNEL);
> +	if (!n->pkg) {
> +		kfree(n);
> +		return;
> +	}
> +
> +	INIT_WORK(&n->work, icm_handle_notification);
>  	n->tb = tb;
>  
>  	queue_work(tb->wq, &n->work);
> -- 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot