Message-ID: <ab387012-c1a8-c3f0-8c84-dadf82ce2d9e@oracle.com>
Date:   Mon, 13 Dec 2021 08:22:13 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v3 3/5] mm_zone: add function to check if managed dma zone
 exists
Content-Language: en-US
To:     Baoquan He <bhe@redhat.com>, linux-kernel@vger.kernel.org
Cc:     linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de,
        cl@linux.com, John.p.donnelly@oracle.com,
        kexec@lists.infradead.org, stable@vger.kernel.org
References: <20211213122712.23805-1-bhe@redhat.com>
 <20211213122712.23805-4-bhe@redhat.com>
From:   john.p.donnelly@oracle.com
In-Reply-To: <20211213122712.23805-4-bhe@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3lDcmdxQ0NFQzNOdWtVdUZ4VFJzMGZWbjM0Vis3ZU5KUHMwd25iRG9BMVFW?=
 =?utf-8?B?MkFHYWZ1bXBFQ1BnYkFXZkY5U3NBVk1ndDB2eTNGZkJzZTdJelEya3FsZEdT?=
 =?utf-8?B?V282d2VoMHp0UGJhNUEwTmpleTZ0TW9aRm00QlVWZXJUaVNFQ0N0ZnFSNUlT?=
 =?utf-8?B?WlJleWRWYUZOMUloZVF1RTluQ2RJaFl5SWRyazZuM0NXbEpKeVQxZUFNSUl0?=
 =?utf-8?B?UUh6eWxyMURVeU5LMTFVdktnRUZPMWZSMERMakExZDdNemJFaGR4WkhXNlNL?=
 =?utf-8?B?MkpNUHh5NjVhbllnR2ExbXE5TjRtSGttd1VIZldTRk1nMG9MVTZqZ2ZySnBP?=
 =?utf-8?B?TThhams2QklDTi82eGFyVnlzUTBBT2hkcTNTRllXd3R4bGc2OGdKOWh3Q0VU?=
 =?utf-8?B?MWtOdlVqOUJUaG9Ga3ErRjJCbWd5NUpIM3hmc3VyRmZLYy9UYVJDVDczTDJm?=
 =?utf-8?B?WCtISm1vOTM5Q3lTN0dGd1JGZTI0dGxiRDNQblRQQ0tWKzF4WGsvQzUxb2cw?=
 =?utf-8?B?SzBjdVA2a1lDelJwUStBRnR4T3JmTitKQ0N6Z0w2NHVVUE56MFZkZ3pjRXN4?=
 =?utf-8?B?RDl3WitSMVYzYThuMllIWEd5ZlpMcW01YU5Jb1lCYzRRYWpRbWZVeWlRSVZE?=
 =?utf-8?B?dTdYZ1pkUkZCb3VMN1Uyb3lsMndjbGlQNHUvU2RObDlRTGJBeUdpaGQrVStM?=
 =?utf-8?B?Y004VWovSzRJYUdiUjd2T2hnV3h1bHl6ODBpR0tST3JiZm15Ri85VkdGWDdw?=
 =?utf-8?B?bnQ2R0lmaU9vUkJSU3MvRGhOTzY3ZWVsZEhoZW9iYjV2SHNyOFBJbFoxRFlZ?=
 =?utf-8?B?R1Y0RkhkM2pLRzZnclYrQVlXemlYWlkrMWZsaEtOZE8xaEFFdG9WbkZDeXdn?=
 =?utf-8?B?S29xeE05MUwyN09hVmdmZjREdlJNUW1jNGQ3RWJMclk1V3hFNGt4SG1mbjhT?=
 =?utf-8?B?T0J6T3pPOEN6UW13ZlZOZnZJeWttRXN1RnZ3MnU1ZmtvL2JOYjNYdVNEVmtm?=
 =?utf-8?B?TkN2NElUeUw2ZVRPL0pkMlhpc1lKT1BqZnl4elpvTS9mMmc3TytMR1U2TU1M?=
 =?utf-8?B?dlIwenpaaElrTm1MWFZWaGtTWmV4dEFPNjlYTTZGeDhVdnRmWm9YUGJodlBh?=
 =?utf-8?B?eG05ejg4Skdud3VXM0xUeE9SeEcyRnJxcHM5VnEwZnpkZ1Z4dHZ1SEVOazN1?=
 =?utf-8?B?YVE2Z0hsZ09pUVRSdkVJVTdHRjVLKzNLVVNaT3hiMVBNMldZaGFtVlAzOVJY?=
 =?utf-8?B?Z1FWeHVtMFFXZWQwQW9MRzF4VUY1OWw5QVp5REJRNlpNSldoMVJNaWhrUXBr?=
 =?utf-8?B?Tk1YMWlJYWtvUlVtTSt1Nk1wQTc5VUhrVTdhTFhsbjNpK1JWOFJOdUlIcS9M?=
 =?utf-8?B?UjNUM3N0UTk2clowQkNpWk9lSFI1aVkvQlRDbktBQmY2N1h0MjFOSTc2bGs3?=
 =?utf-8?B?dnNlNlJFNk42dzhGdmoyNzkzSTNVUzllWUltREVSOVpDV2xyYnZrWlp0bTBG?=
 =?utf-8?B?ak9HclR2N1FCUXNLSE1XZ1N2WUZadUVxT3F4RUt0YW9sR2w2MmNxeU1MYjhx?=
 =?utf-8?B?bDRiSjhMK0lrT0lTdjE1dTl5K0pLMWpoMlNVOEEyVlliY3R0Lzg5RzJ1RXRQ?=
 =?utf-8?B?Q2VwaFo0ZHBTckNYVitQMnUxOTd2cG53Q3c0VTNwVHQrYzR4UUFZQXh6Risx?=
 =?utf-8?B?V1c0TnRJM0x5anhyVm9sRXMvVUh2YmFmdkowMXB2M0dDeEhjZkZSZ2Q1bkpq?=
 =?utf-8?B?SkJ1QjhVaWdHcVNSdGdTVnFDdmZYTml3a1VjaXF6emxPMS9vcVNWN0kxV0lw?=
 =?utf-8?B?UEN6U2VESTVaa1Rvcm55ZFlUampEeTJ5cW1LL2NaQzRzekdJR1I4cUFMRXVh?=
 =?utf-8?B?U3diUjhvU09STkNteHFSTnZMb0VSSG1kVXJRTUU2TWovc2Q4WXNIWVVBUUZo?=
 =?utf-8?B?NzAreWc0TVVsMWQ3Vm5SZFM1a3d6UDY0akllSjd4Znk0V1JYd0JTRTg0VTl4?=
 =?utf-8?B?QWFVeXo5cjhCdkI2Q3d2RmE1YWZqL2R5bWRzb0s4MUNQdk5zL3dNTlhWejB1?=
 =?utf-8?B?TWxkLzdBb29ldGxtNEFCWDhQQ2w3cCsySFNobUtXcVdZV0xhSU1ISm5YUktM?=
 =?utf-8?B?Z2dtejdkZC9ac3d4ZzhNZmFtR2ZLalZxRFBRSllSb1MvK1pIblMyNXYraml4?=
 =?utf-8?B?OTFCdDlNUm96WDhRSExXNXRRQ29UeUozZ2dDK1dQaHhzRkc2QVV3QkdqZVdu?=
 =?utf-8?B?aDJMN2FMd2dGMmJhSXM4Y0o2NGJnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 137eeb7f-b26a-4964-65ff-08d9be43f867
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 14:22:19.1747
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F8su5N+k2ueIFuc8mJIyWJBlZ6GLBoxgDM+8wXS2w29ODDSjHyRZyJtBBsJRl/yYmV0nKPKp2ISP0EL9cufgF8TqgbRDy7zwWPzc6/P1NE4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1517
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10196 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112130091
X-Proofpoint-GUID: PgvKXQbGvP6No9dexDukjrHphqIn6DPo
X-Proofpoint-ORIG-GUID: PgvKXQbGvP6No9dexDukjrHphqIn6DPo
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/13/21 6:27 AM, Baoquan He wrote:
> In some places of the current kernel, it assumes that dma zone must have
> managed pages if CONFIG_ZONE_DMA is enabled. While this is not always true.
> E.g in kdump kernel of x86_64, only low 1M is presented and locked down
> at very early stage of boot, so that there's no managed pages at all in
> DMA zone. This exception will always cause page allocation failure if page
> is requested from DMA zone.
> 
> Here add function has_managed_dma() and the relevant helper functions to
> check if there's DMA zone with managed pages. It will be used in later
> patches.
> 
> Fixes: 6f599d84231f ("x86/kdump: Always reserve the low 1M when the crashkernel option is specified")
> Cc: stable@vger.kernel.org
> Signed-off-by: Baoquan He <bhe@redhat.com>

 >
  Acked-by: John Donnelly <john.p.donnelly@oracle.com>
  Tested-by:  John Donnelly <john.p.donnelly@oracle.com>

> ---
> v2->v3:
>   Rewrite has_managed_dma() in a simpler and more efficient way which is
>   sugggested by DavidH.
> 
>   include/linux/mmzone.h |  9 +++++++++
>   mm/page_alloc.c        | 15 +++++++++++++++
>   2 files changed, 24 insertions(+)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 58e744b78c2c..6e1b726e9adf 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -1046,6 +1046,15 @@ static inline int is_highmem_idx(enum zone_type idx)
>   #endif
>   }
>   
> +#ifdef CONFIG_ZONE_DMA
> +bool has_managed_dma(void);
> +#else
> +static inline bool has_managed_dma(void)
> +{
> +	return false;
> +}
> +#endif
> +
>   /**
>    * is_highmem - helper function to quickly check if a struct zone is a
>    *              highmem zone or not.  This is an attempt to keep references
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index c5952749ad40..7c7a0b5de2ff 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -9460,3 +9460,18 @@ bool take_page_off_buddy(struct page *page)
>   	return ret;
>   }
>   #endif
> +
> +#ifdef CONFIG_ZONE_DMA
> +bool has_managed_dma(void)
> +{
> +	struct pglist_data *pgdat;
> +
> +	for_each_online_pgdat(pgdat) {
> +		struct zone *zone = &pgdat->node_zones[ZONE_DMA];
> +
> +		if (managed_zone(zone))
> +			return true;
> +	}
> +	return false;
> +}
> +#endif /* CONFIG_ZONE_DMA */