Message-ID: <01cf00c1-0371-b896-9a76-78df036e2b02@oracle.com>
Date:   Mon, 13 Dec 2021 08:26:29 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v17 01/10] x86: kdump: replace the hard-coded alignment
 with macro CRASH_ALIGN
Content-Language: en-US
To:     Zhen Lei <thunder.leizhen@huawei.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
        linux-kernel@vger.kernel.org, Dave Young <dyoung@redhat.com>,
        Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
        Eric Biederman <ebiederm@xmission.com>,
        kexec@lists.infradead.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        linux-doc@vger.kernel.org
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        Feng Zhou <zhoufeng.zf@bytedance.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Chen Zhou <dingguo.cz@antgroup.com>
References: <20211210065533.2023-1-thunder.leizhen@huawei.com>
 <20211210065533.2023-2-thunder.leizhen@huawei.com>
From:   john.p.donnelly@oracle.com
In-Reply-To: <20211210065533.2023-2-thunder.leizhen@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0ZJZFhGU1lDeDlLSG9nNGl6bVBCZXpiZzRnWUliRVliVnEwYzBCamQyWFo1?=
 =?utf-8?B?Rzc3TW1DV01XekYrQ29QUG5rWktVN1VGUTVQMDRKVDhod3lsV2Z4ajNjV1lr?=
 =?utf-8?B?R3NETlQxdmNselJuT3VCaHp6UUVGbnRTakZ4TWtueS9wZXhWSVU3MWthSHVj?=
 =?utf-8?B?aWI3Qnc1bEZNdHQ0MFUwamk2TzhnZHJ5NE03RHllTEJuQkdzNlVWWWt6WWJN?=
 =?utf-8?B?KzZKWHdQSmNtVDFNNE5obFhneTJMeEZLZkhVWWFmQ3dwSkhVQ1Mwdi96WnBj?=
 =?utf-8?B?cUs1Q1Y0SEE3TVdqSHd1bHF0elAyUmtlNmp0eExRZ04wamFiSEQwb0V2TGJI?=
 =?utf-8?B?ZUdtUWhzNm1QZ0RhaXVEOFNVTGJTcVlqRXl3OG5RdjJnV1c3SlFKdnpnV1lv?=
 =?utf-8?B?QkF4N3o1VjRjN1ZKaFdLWEdneTg1TTV2elZDWVFJWTE5OERXNDBPdC9pS242?=
 =?utf-8?B?SUZhamlycm95ODlITVNQcGVuT0IzeXpOZzc0ejI5RXFORCtZT3dnbTVhaWlI?=
 =?utf-8?B?UEE1QVNobEdWWnJvazFQc01SaFl4RzJCeTA1c3lxbXI5Yk1qUVdHSXhxS2pz?=
 =?utf-8?B?WjJNdmdwd0VTakduVG5RQW42dXI2azluK2NZNTBqQlk1OW5Fcm9YOU5rRkVU?=
 =?utf-8?B?OE53aXc3V3hISVRFZDI0L0lJTEN2M0c0N1owVXFBL3FzdnJEVFdCNE04RmJm?=
 =?utf-8?B?RjhoTm10dDVCdkIwOHhZWXE3YzlQdSswa2hRRS9GNVI4VzFHdHpaODZuMm90?=
 =?utf-8?B?WlBPY3ZNMGlIbzdGMk56V2Yyc1BIL2FFYkhtd3hQSlJLVndwMU5uSkI0dm5G?=
 =?utf-8?B?OFBURzRzOFdhNDRTU1lpeG9Oa1lLb24wY0hBd1AvcENYWGZZOXY5aVdBaFVB?=
 =?utf-8?B?VENxUEhueUFYNjFLRERHSVJHV2VZQUYvOWFCamtPckxMSTllenJodWJhQk8z?=
 =?utf-8?B?T24xOEZPQXhjS0JOdnZSdThFNDdHNWtQbWIzY29qT1lwUkNGejlJcDBMN3NG?=
 =?utf-8?B?cldSK3hlbmgwSkJFVzc0MENsU0RKNTE5VHg3WmFUWm8ycTFCQ2FNN1BhN05s?=
 =?utf-8?B?YkliWS8wUTV2NVhJcnQ2U2ZUNllFMFZGYXd0Y0J1UnBJUHo3T1dhajZ2ekVm?=
 =?utf-8?B?eEU2aUxhSUVrMjA4U0tuampnV3dFM1NCR21MM25TTzJJa2h6eVZwM3pVM1RR?=
 =?utf-8?B?cG5sVHE1Ykh4eXhIdFBQcWxOVmRpMXI1dlVDQWRCeFFaMFE5cXNlVWF6em5l?=
 =?utf-8?B?Y1lMR2J5ZnVFODRRQloyOWJzOXN4ZWw4bGxFY1UyZElrSWhRYm1OU2hGL0J4?=
 =?utf-8?B?empTeHUzdlJ2U0hoTXdzMHFteDhxUUpJOG9LRDl4OXRlbFp5ZTZnQmtmSnp4?=
 =?utf-8?B?L3lBWm9IeW5NbDZsZzlzZ3QzYllCaTliSmNLYk9RR0RJQVVlVEVvVUdaYlJG?=
 =?utf-8?B?YzIwZGhNbnYxdWlVNk9xVmR0WWludDZZVFcxM21od0pUUCtvSFNpVWxkbGht?=
 =?utf-8?B?ZkkxT05ySnp1M0dDZWF0cFRubEhYTGV0MnNSa3lIQlZKZEFUTXFFVmVyTVNt?=
 =?utf-8?B?SlVlZlByM1ZNbDROcHNiSkVBcGlHY3owRWV2ZlQ5ZSs2alBWUUtSZ2l3Z1RT?=
 =?utf-8?B?OTNvNFhNbUJzbU9OVGRjaEJSOTFtWkc1cnkxT014TnNHNTVTaXVpQ2doSUJ2?=
 =?utf-8?B?OGtTRzRlc1JhU2gzS1c1U3d1Q05oYUlsRVplckZHZm1ZN1JXclZSSUMveDFL?=
 =?utf-8?B?QnZGU0pZN0h5TFY0d2dJUnN4dTEvbzlTaksvZU5Kbm0zZDQzSjJtd1U1N3FL?=
 =?utf-8?B?TXpBYisyOUsvamgxcndBZXhrdExsYTlCNFBiQjhvaHdXK041M21SM1VLOWNP?=
 =?utf-8?B?NzA4YjlwYXMyVXNhRnh1T3pzaThSZGM0MlAybS9rVXhmaWtpenFvcHVMV0Zy?=
 =?utf-8?B?N3QwamJnM2hxZjRwczJXNDJnOXZ4bXNZbnR6Nk1vQ3k3VTQxS25KNm1iNzF3?=
 =?utf-8?B?SUpuTFBGSkdQZXBHRUtCRis3NjBSZXh2am0zK3A5a2dFVjVpcTZKa1ZjUGtG?=
 =?utf-8?B?dXdJL3hxWVFIZk9qazVDVGQrWlN1em4rVVkvemtqSDZxU2IvQk93RU9ld0RZ?=
 =?utf-8?B?elp4d0dNZ1dMT1IyMG9EcHlUdmJzUnNJU01KTjNnYU5kVCtTLzBhUGxaMkN3?=
 =?utf-8?B?OVU2QjVGQmF5VzZNZFdNdjNBMG02aEo0c3JGV1VVRkJzM3UvTDgreTFlTVFl?=
 =?utf-8?Q?IB6iwfy4ZI3ynw60AXGcxda/ubbsLoLCOkKEKo1qr8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63a0e1ec-e972-430d-fe6d-08d9be449641
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 14:26:43.9632
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +95Db6ydzt6hrVsN9qXRlNJeH/LxWrxQijxqL7BNUpaP6guh6VzWZgPziZZmfKHPT1c36Y2Pv9zVKil/clJxD6zcuH3x5UASRJqcxnkc03w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1966
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10196 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112130092
X-Proofpoint-ORIG-GUID: Il_pMC_39Pmcc-HAamw6bIVPQMYrzauo
X-Proofpoint-GUID: Il_pMC_39Pmcc-HAamw6bIVPQMYrzauo
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/10/21 12:55 AM, Zhen Lei wrote:
> From: Chen Zhou <chenzhou10@huawei.com>
> 
> Move CRASH_ALIGN to header asm/kexec.h for later use.
> 
> Suggested-by: Dave Young <dyoung@redhat.com>
> Suggested-by: Baoquan He <bhe@redhat.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> Tested-by: John Donnelly <John.p.donnelly@oracle.com>
> Tested-by: Dave Kleikamp <dave.kleikamp@oracle.com>
 >
  Acked-by: John Donnelly <john.p.donnelly@oracle.com>


> ---
>   arch/x86/include/asm/kexec.h | 3 +++
>   arch/x86/kernel/setup.c      | 3 ---
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/include/asm/kexec.h b/arch/x86/include/asm/kexec.h
> index 11b7c06e2828c30..3a22e65262aa70b 100644
> --- a/arch/x86/include/asm/kexec.h
> +++ b/arch/x86/include/asm/kexec.h
> @@ -18,6 +18,9 @@
>   
>   # define KEXEC_CONTROL_CODE_MAX_SIZE	2048
>   
> +/* 16M alignment for crash kernel regions */
> +#define CRASH_ALIGN		SZ_16M
> +
>   #ifndef __ASSEMBLY__
>   
>   #include <linux/string.h>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 6a190c7f4d71b05..5cc60996eac56d6 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -392,9 +392,6 @@ static void __init memblock_x86_reserve_range_setup_data(void)
>   
>   #ifdef CONFIG_KEXEC_CORE
>   
> -/* 16M alignment for crash kernel regions */
> -#define CRASH_ALIGN		SZ_16M
> -
>   /*
>    * Keep the crash kernel below this limit.
>    *