Message-ID: <7ffcc677-a557-5453-c866-9ee17d2e760f@oracle.com>
Date:   Mon, 13 Dec 2021 08:27:20 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v17 02/10] x86: kdump: make the lower bound of crash
 kernel reservation consistent
Content-Language: en-US
To:     Zhen Lei <thunder.leizhen@huawei.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
        linux-kernel@vger.kernel.org, Dave Young <dyoung@redhat.com>,
        Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
        Eric Biederman <ebiederm@xmission.com>,
        kexec@lists.infradead.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        linux-doc@vger.kernel.org
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        Feng Zhou <zhoufeng.zf@bytedance.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Chen Zhou <dingguo.cz@antgroup.com>
References: <20211210065533.2023-1-thunder.leizhen@huawei.com>
 <20211210065533.2023-3-thunder.leizhen@huawei.com>
From:   john.p.donnelly@oracle.com
In-Reply-To: <20211210065533.2023-3-thunder.leizhen@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2V4bE82QXRoZWhKZU4yUHdEVWROeGlsS0pJc3VwK0x1VVhWNkpnSUtNK1VP?=
 =?utf-8?B?UTJKQWNoa3RiUjg2RWtjejZXYm51cFNBaVVqdjJGVjVnMmNFUXpCa3ZNN01m?=
 =?utf-8?B?SURhRjloRFFrVjhVMngrdUlQQ2xyNitTZzR0OHNoMDRUb1hhRXVacTFRMmZM?=
 =?utf-8?B?bUM3aE0wMkh3cW54UFZxZ0xzRlVzeUJJclFzelZIdnliQVovWVJHTWgwS2Mr?=
 =?utf-8?B?V2Y3T0QxeUo1SGU4cjd4dllqWFRad1R4bW8xb3ZMVnRZblV4VTMzUmx5aG15?=
 =?utf-8?B?QWMwdUtnZnhqYkx0ZWZVV3ZVWGtLUnJvTlI1SHgyN2RDTG9rZTIwb2RFd3M2?=
 =?utf-8?B?V1N4bnV0WDd4dWtTTE1DNmtSak9IZGJSUE1iWFBxMXlHaEYxbWpaWitFYkFS?=
 =?utf-8?B?TENaTXc5TmNISllPUm1YTHF0VzR1NFdpMk1HTE9mTlZhVFV4TmVKZmJtclVN?=
 =?utf-8?B?Tm1GOXRJRnNpU2ozT3QvcWdqOTZZcm5LWktrYW40dE9Gby9WYllINnhURnBk?=
 =?utf-8?B?S3g1RjArbjRyUWpKc091dWRjNU81amYxc3FZYjlYVGJveGd2VmU5dTUyN2dO?=
 =?utf-8?B?WEVNK1RicTYrLzhwYjY3NjllajB3S2hLZlY0T2xscFdkZ0w1L1I4U1dsSDJn?=
 =?utf-8?B?RVRSeEdGNjRmcjlQU2QvMW9IWWFvL1lkaFowbzlkRzZDYlY2UUFLYjRDa3JN?=
 =?utf-8?B?QzM0ZEYyaWUvTjNxNlJMVnYxU2s2b09BNjZVRGI0ZzJRNHRuUG1QTTFtRUVr?=
 =?utf-8?B?YjYydVc1bTFuMkZDZitRd2M1ZXpueWU0V00ybDRXTkNpZlVSMXN2c0RiUWJl?=
 =?utf-8?B?cmZ1TG9NTmhLeFN0UHBTcGlxNGdhMXl6eW90QVlGMmlDZFAvVzdSWS9rREZL?=
 =?utf-8?B?V2dzUENzY0gyUDZ0NTJldWxyaFVLY1FTd2NwMEZwRUh3ZzgzemlGTkJJL3lY?=
 =?utf-8?B?ZVorS3hicmtZMWN3Z21YV3pNNDN1T3NNeUdLZlhhRTNxRFZUdlJITExYdHdh?=
 =?utf-8?B?ajg1WjlOSStoMlAyWkNsMUM2aElVcTVVZTViNTRIL2Q1N2lydWwwZXNlSXFs?=
 =?utf-8?B?Z2Q4U2lnM3dpZlppeGIyZ3B3cFFqQUNBbWxHb3FrRHVHdkJOdXJLeHJMOGJo?=
 =?utf-8?B?UE1NZ0NudlUxRUhSekpNTmRkekJpZ0xGNlcwK0pOQ0xWWnpqWkV4cFpuSmMw?=
 =?utf-8?B?aGZtNDJoQWlLWkRXVmZ0SWVRN0thWGNqS1BtRnRaT1MzbWNwckEzSm8wNlk2?=
 =?utf-8?B?NmdvWFA5K00vemxUVURDNHVFRjlsbVJhWjdya1RJRzhsU1M0ekg0c3M4WlIr?=
 =?utf-8?B?clQ1TnZLcjBFS2JaV2tNTXI0M0d2clp2WjJFQ0l5L3R5Q2hnb0I2N0wvbDFj?=
 =?utf-8?B?VURXVWJRMm1QQXU1dEJ1RlREVWowL000WkczdlZwWmphcE1aVFRrZ3dxVmFh?=
 =?utf-8?B?a1Jtbkw1WnU0RHJiRGxJMER0Y2VzQlZmSy8zbGlVUFlvNDZEY0srZUdiNUJ6?=
 =?utf-8?B?eWR2N0FpYUdVeXNlVFQ2Wm12ZXQ0NmkwbGZJdDZhd0lBMGJ1eVFiQzZiSk1T?=
 =?utf-8?B?MXRxTkdjN3B0U3lwZTFxZDViSkNhYXZvRHJXcmZMem1SSlNJYnoydHV5NWw3?=
 =?utf-8?B?QTh6UDg2KzdsYyt0dnpSVEdDaTdGUWU4Q3pNbThOd3lSb3FmOGlIY0NsYmox?=
 =?utf-8?B?QTQvSlVPNThOYVdSVkFqS2J4dlErVzBjK3FnL0o2NmtVR1cyaWRLSGZ0VUN2?=
 =?utf-8?B?V3pxSVlPL3ZPWnBqSzlsQVc0Q1NIdXJtNUlkSmpVc1ordXFEVFRXcVk0UVk0?=
 =?utf-8?B?dk0rZlQzOFYvWlAySDNlejZVVVpOTit4SXV1SHREZFBManFnRU9DY2JkdTRK?=
 =?utf-8?B?ZDRiNS9CbHZ1Y3N4RzB2bUFsWEprdC9PSUtRMGo0MkR5M2ZtYndYaWVWZ0ZM?=
 =?utf-8?B?Q29ndGszaVBxTlVXL0Eyb2xvbDR2N2ozbDJIdDRxN05RRVY4MlE0cTNoMDdi?=
 =?utf-8?B?TnUvY2ZXL3VVL0lvNUFmQ3ZmejFzS2dyOU0rWlorMFk1NVlnMm94SEtiSTgr?=
 =?utf-8?B?TC9XM25TaXNwTXFQUWZsbmZWZ0tMbStZMnNadUtYUUJLYXpMNWVpaFFReTZ3?=
 =?utf-8?B?V3U0dithSXhwZnpQa3JLdmRaa0dYcklBRm9WS2gvUkFscWg4QzZDTlZaSk9U?=
 =?utf-8?B?UmU2MTFrN1dJODRHTTRqdzU1eEdtTFZXWHpOeHM2Vm1kVG5zZUgxKzhNbmtx?=
 =?utf-8?Q?gMwZnyGa8uXccJEtJy7YMmPCeHbdk0UvveIJUk2vGE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54953cfd-764c-4cf2-d385-08d9be44b460
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 14:27:34.6214
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wwloc+WIR6FfQpBdb7SXXJQlVlm7i9NT2IjF5lX3TPaR+27LRxIFyxHvi7n4kYz21UxCINwwDccvlTEZgcNmOnSKh59NzRRuNcwgf7qLlQ4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB2047
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10196 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112130092
X-Proofpoint-GUID: QeT3LsmSFOBBlqoFze81x3Jv-fGJScxv
X-Proofpoint-ORIG-GUID: QeT3LsmSFOBBlqoFze81x3Jv-fGJScxv
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/10/21 12:55 AM, Zhen Lei wrote:
> From: Chen Zhou <chenzhou10@huawei.com>
> 
> The lower bounds of crash kernel reservation and crash kernel low
> reservation are different, use the consistent value CRASH_ALIGN.
> 
> Suggested-by: Dave Young <dyoung@redhat.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> Tested-by: John Donnelly <John.p.donnelly@oracle.com>
> Tested-by: Dave Kleikamp <dave.kleikamp@oracle.com>

  Acked-by: John Donnelly <john.p.donnelly@oracle.com>

> ---
>   arch/x86/kernel/setup.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 5cc60996eac56d6..6424ee4f23da2cf 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -441,7 +441,8 @@ static int __init reserve_crashkernel_low(void)
>   			return 0;
>   	}
>   
> -	low_base = memblock_phys_alloc_range(low_size, CRASH_ALIGN, 0, CRASH_ADDR_LOW_MAX);
> +	low_base = memblock_phys_alloc_range(low_size, CRASH_ALIGN, CRASH_ALIGN,
> +			CRASH_ADDR_LOW_MAX);
>   	if (!low_base) {
>   		pr_err("Cannot reserve %ldMB crashkernel low memory, please try smaller size.\n",
>   		       (unsigned long)(low_size >> 20));