Message-ID: <7d2bd373-37e4-2690-8b2d-e931f5036317@oracle.com>
Date:   Mon, 13 Dec 2021 08:33:07 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v17 09/10] of: fdt: Add memory for devices by DT property
 "linux,usable-memory-range"
Content-Language: en-US
To:     Zhen Lei <thunder.leizhen@huawei.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
        linux-kernel@vger.kernel.org, Dave Young <dyoung@redhat.com>,
        Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
        Eric Biederman <ebiederm@xmission.com>,
        kexec@lists.infradead.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        linux-doc@vger.kernel.org
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        Feng Zhou <zhoufeng.zf@bytedance.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Chen Zhou <dingguo.cz@antgroup.com>
References: <20211210065533.2023-1-thunder.leizhen@huawei.com>
 <20211210065533.2023-10-thunder.leizhen@huawei.com>
From:   john.p.donnelly@oracle.com
In-Reply-To: <20211210065533.2023-10-thunder.leizhen@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUltN1VINitrNkErYnl5ZndTSzlVL0paRXE4ZWxCeWh0eUFPMkNKN1pvU0pY?=
 =?utf-8?B?TGJDcWc1RGhHcTVLTDJaTjA5Z3pJVzU3elFPZU1HU0U3cFdHeDUrbnlRcEpp?=
 =?utf-8?B?MGVxK0NLaElkcy9hdm0xY09KR3FhMWNzbVJWM09kVXVJMHBKaVUrYitaRHN3?=
 =?utf-8?B?MVNBcVBvTlNrcmY5aStQanMreDlDSmN2L2w0QUlpZ0J4dWViMzVtNDEzd2xE?=
 =?utf-8?B?dnhyUklVc2lOZzZMUzFqUGxla1NMUDM1dmNRNG1nMm5QNXR3S1NmalRNNm56?=
 =?utf-8?B?ZDA5TFlPMlFEMmh6UDIxb29NNE5UMm1NR3BoK0YyQWZOd044d1VzZ1RsZEti?=
 =?utf-8?B?QWthZzRTNTZRbnlwajc3aGh2MG9zQkgxUDBDRHJlangwNWI5M1UvcXRxUStk?=
 =?utf-8?B?NDVkUnBxNXkvQmdDRFI3dWRrNzFlbWNFV1pkUDBSQjhJZm12YnVVQ2pLYkRI?=
 =?utf-8?B?bWFQTmxQQmUrNjRtQnhNR2lEazZlejZmaCsxUWs4Mm5PV3k5bmQzQ21vbi9z?=
 =?utf-8?B?bDNhM0tvYVBCSVo0TTlZOUNGVXp1Q1RhNDhaUVRneXRqMGdBdlIxbE11VXFF?=
 =?utf-8?B?b1RSbUpzS0F0bUFqcGhsNWxtaWE0azBoWGRyRTIrZGdNc0Rua1BjY2FRcm90?=
 =?utf-8?B?Qy85eGl1Z3JZcFNQYWlndmY1UVY5WEdoSzVNZmRJUDNmdksxVWZMbnBZOTFI?=
 =?utf-8?B?VS9Ga21RVmlHOVJuNXVpbXJ0K0t4U2VuS0U5WGE0QXVTVU5PdkJVQkZ1Z2Fl?=
 =?utf-8?B?M3k5bW0wNmNyNEoyMzUyM3JkNkczSk1NMGpsZVV3MHIvK2xseHB6bnRvYVVH?=
 =?utf-8?B?MWZ5VnZINDZIUEFSNVJpb3ByYVc0SWVZQ1BQN2RMTDcxZEtmd3FlZzYwazky?=
 =?utf-8?B?ZkJqSStSNW54cWtPL0dSUUdYVi84bVphUnAwbUdYaDNhK2V2VkJVWVBPdzNM?=
 =?utf-8?B?aHlZUmE2Q3gyR3BoNFhhbk8vZ3lySnhYcHk1d01wWW9GQjJtNTdscWhKYTRk?=
 =?utf-8?B?L1ljeDBPSE5pajdTT0V2NGdsY3l5UEVEajNiVzZqZmcxRHVyZlhKN2Y5bFY1?=
 =?utf-8?B?VTExZzREVG05eWpURnV4YzFYQ2NBVFY5dnRPbEJYd081czluMXN3MVY5RTFH?=
 =?utf-8?B?U2FaK3V0OWc3R2psOGYyN25GOGd4UlcwbUZVbThhZmJqOTBQd2sxNkNXSHp5?=
 =?utf-8?B?aXo0RGpWNEI0LzdMU1ZwWSsxVTgrejQ5SjVGQ3A5MUJkUFYxbTJyTGlmakFZ?=
 =?utf-8?B?WVQwakIyNGJMaldNblh5c0FnQWQzeVlyUmMzYi9HNXBuTjdwMFg5WDVxWWg1?=
 =?utf-8?B?OWNrVjdBRkw0M3h5dkdYZ1gycjdhMnR3RnEydWN3WGNFczROZTBaeHRwMlVX?=
 =?utf-8?B?bTBVUUs1bEZhK2Y1RE84T2ZoTXJTN0k3c2ppQkdKaHNiemNham9LTjhaOU9s?=
 =?utf-8?B?b0JKcmc1aldBOWlyL0JRNE9VbW1uZVlkVTloQXZieTlOZzBZbDZsMllSNmFr?=
 =?utf-8?B?YWNvU0pGQlo5cldKR3l6bkR2SHM1Z1YxT1NNaGY0SW5BeUFyMGJ2Z2ZyNnY4?=
 =?utf-8?B?YUErR1FMaG9lcEZNQWFxMndwd3ZMY3Vld2U2V2hnM1NuQ0RWcWkwckk1V3B4?=
 =?utf-8?B?ZWdUOW42TnNtb1pSSndPNHVPeDV0RXJFM0ZCZHp2amFKVWJmU2VTQ2E3RHlX?=
 =?utf-8?B?aVJxZkdFVFBxMUZPTUkzRllnMHZ5dEFxYUFrU1dHdmdSNUxlS1R5Ky8ySnFo?=
 =?utf-8?B?MmI4N2t1QWJ2MHBQU0FJaUk3TTVHVkN2U2lsMGVrRkg0eGdRWjdzSVh2Q0c1?=
 =?utf-8?B?eG5ydEVvQnE5NWVvckF3MW1jbnJ0T0RtZDk5cDdFWlpWeGZIbDc1OGU0WXgy?=
 =?utf-8?B?c29ISlVhL0s5U1FLa0djM3V0RXJYbVVCempmM2lyb1RQbmdlQnZIYnI1anVk?=
 =?utf-8?B?UmJXUzRhZmlSTTJ2bHJkL2lucFRiUkRKaXQzTk1QMVRWNmpUczcvWVJqczlL?=
 =?utf-8?B?Z3NVLytzcExwakZNc2pQOC9OSndHZ3JZanVpQlNmZHllQ2ErMTByc1I3WlJE?=
 =?utf-8?B?SmovMmdSZVRnUklNWHZ3Wk1JNlpSSXM3elJHUFU5RVR5aTY1R0NKdzRKeEJS?=
 =?utf-8?B?U1ZwdjQ2QzdKYmxpUmVMUzFEOUJ6TUwyWUMrOFVjZVZJbEI2cjBBMDM1MWlD?=
 =?utf-8?B?Mm1NZ1JYYTVCVmlCbzc5dW13TXlITHJlbVZOaXlKbU1WaWRkQzJjVmFxMzBk?=
 =?utf-8?Q?t7acb06mFpj8ZoqDiiQdd7+tDkYOJ8XcGiTa/b87ik=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f95eeaaf-5317-437a-07d4-08d9be457ee1
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 14:33:14.2833
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yus8MOCDQ0+1vr/OFz+JnXwMsqkGRC1xYgUw5XPZHjc067LKHqzvlYhDDIXJlQfBGhIgWvgnXNCzZCeFdJV71bv0Nm7IpxVAE6YZ5+mhmao=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1629
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10196 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 malwarescore=0 bulkscore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112130092
X-Proofpoint-ORIG-GUID: uZx_h6sI99DNnYo-XVWIGHwNxUCfZ7bp
X-Proofpoint-GUID: uZx_h6sI99DNnYo-XVWIGHwNxUCfZ7bp
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/10/21 12:55 AM, Zhen Lei wrote:
> From: Chen Zhou <chenzhou10@huawei.com>
> 
> When reserving crashkernel in high memory, some low memory is reserved
> for crash dump kernel devices and never mapped by the first kernel.
> This memory range is advertised to crash dump kernel via DT property
> under /chosen,
>          linux,usable-memory-range = <BASE1 SIZE1 [BASE2 SIZE2]>
> 
> We reused the DT property linux,usable-memory-range and made the low
> memory region as the second range "BASE2 SIZE2", which keeps compatibility
> with existing user-space and older kdump kernels.
> 
> Crash dump kernel reads this property at boot time and call memblock_add()
> to add the low memory region after memblock_cap_memory_range() has been
> called.
> 
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> Tested-by: Dave Kleikamp <dave.kleikamp@oracle.com>

  Acked-by: John Donnelly <john.p.donnelly@oracle.com>

> ---
>   drivers/of/fdt.c | 33 +++++++++++++++++++++++----------
>   1 file changed, 23 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 37b477a51175359..f7b72fa773250ad 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -967,6 +967,15 @@ static void __init early_init_dt_check_for_elfcorehdr(unsigned long node)
>   
>   static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND;
>   
> +/*
> + * The main usage of linux,usable-memory-range is for crash dump kernel.
> + * Originally, the number of usable-memory regions is one. Now there may
> + * be two regions, low region and high region.
> + * To make compatibility with existing user-space and older kdump, the low
> + * region is always the last range of linux,usable-memory-range if exist.
> + */
> +#define MAX_USABLE_RANGES		2
> +
>   /**
>    * early_init_dt_check_for_usable_mem_range - Decode usable memory range
>    * location from flat tree
> @@ -974,10 +983,9 @@ static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND;
>    */
>   static void __init early_init_dt_check_for_usable_mem_range(unsigned long node)
>   {
> -	const __be32 *prop;
> -	int len;
> -	phys_addr_t cap_mem_addr;
> -	phys_addr_t cap_mem_size;
> +	struct memblock_region rgn[MAX_USABLE_RANGES] = {0};
> +	const __be32 *prop, *endp;
> +	int len, i;
>   
>   	if ((long)node < 0)
>   		return;
> @@ -985,16 +993,21 @@ static void __init early_init_dt_check_for_usable_mem_range(unsigned long node)
>   	pr_debug("Looking for usable-memory-range property... ");
>   
>   	prop = of_get_flat_dt_prop(node, "linux,usable-memory-range", &len);
> -	if (!prop || (len < (dt_root_addr_cells + dt_root_size_cells)))
> +	if (!prop || (len % (dt_root_addr_cells + dt_root_size_cells)))
>   		return;
>   
> -	cap_mem_addr = dt_mem_next_cell(dt_root_addr_cells, &prop);
> -	cap_mem_size = dt_mem_next_cell(dt_root_size_cells, &prop);
> +	endp = prop + (len / sizeof(__be32));
> +	for (i = 0; i < MAX_USABLE_RANGES && prop < endp; i++) {
> +		rgn[i].base = dt_mem_next_cell(dt_root_addr_cells, &prop);
> +		rgn[i].size = dt_mem_next_cell(dt_root_size_cells, &prop);
>   
> -	pr_debug("cap_mem_start=%pa cap_mem_size=%pa\n", &cap_mem_addr,
> -		 &cap_mem_size);
> +		pr_debug("cap_mem_regions[%d]: base=%pa, size=%pa\n",
> +			 i, &rgn[i].base, &rgn[i].size);
> +	}
>   
> -	memblock_cap_memory_range(cap_mem_addr, cap_mem_size);
> +	memblock_cap_memory_range(rgn[0].base, rgn[0].size);
> +	for (i = 1; i < MAX_USABLE_RANGES && rgn[i].size; i++)
> +		memblock_add(rgn[i].base, rgn[i].size);
>   }
>   
>   #ifdef CONFIG_SERIAL_EARLYCON