Date:   Mon, 13 Dec 2021 09:59:30 -0600
From:   Nishanth Menon <nm@ti.com>
To:     Miaoqian Lin <linmq006@gmail.com>
CC:     Santosh Shilimkar <ssantosh@kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] soc: ti: Fix NULL vs IS_ERR() checking in dma_init
Message-ID: <20211213155930.mcxlc5m3niqh77xi@annotate>
References: <20211212071301.3011-1-linmq006@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211212071301.3011-1-linmq006@gmail.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 07:13-20211212, Miaoqian Lin wrote:
> Since devm_ioremap_resource() function return error pointers.
> The pktdma_get_regs() function does not return NULL, It return error
> pointers too. Using IS_ERR() to check the return value to fix this.

Thanks.. but..
> 
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>  drivers/soc/ti/knav_dma.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c
> index 591d14ebcb11..9f82cf906949 100644
> --- a/drivers/soc/ti/knav_dma.c
> +++ b/drivers/soc/ti/knav_dma.c
> @@ -646,31 +646,31 @@ static int dma_init(struct device_node *cloud, struct device_node *dma_node)
>  	}

[...]

>  
>  	dma->reg_tx_chan = pktdma_get_regs(dma, node, 1, &size);
> -	if (!dma->reg_tx_chan)
> -		return -ENODEV;
> +	if (IS_ERR(dma->reg_tx_cha))
> +		return PTR_ERR(dma->reg_tx_cha);

Did you mean reg_tx_chan instead of reg_tx_cha ?


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D