Message-ID: <383e4f24-8165-7aab-40af-52340c09de46@redhat.com>
Date:   Mon, 13 Dec 2021 11:31:44 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH -next] lockdep: Use memset_startat() helper in
 reinit_class()
Content-Language: en-US
To:     Xiu Jianfeng <xiujianfeng@huawei.com>, peterz@infradead.org,
        mingo@redhat.com, will@kernel.org, boqun.feng@gmail.com
Cc:     wangweiyang2@huawei.com, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, keescook@chromium.org
References: <20211213132618.105737-1-xiujianfeng@huawei.com>
From:   Waiman Long <longman@redhat.com>
In-Reply-To: <20211213132618.105737-1-xiujianfeng@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/13/21 08:26, Xiu Jianfeng wrote:
> use memset_startat() helper to simplify the code, there is no functional
> change in this patch.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
>   kernel/locking/lockdep.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index 4a882f83aeb9..89b3df51fd98 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -6011,13 +6011,10 @@ static void zap_class(struct pending_free *pf, struct lock_class *class)
>   
>   static void reinit_class(struct lock_class *class)
>   {
> -	void *const p = class;
> -	const unsigned int offset = offsetof(struct lock_class, key);
> -
>   	WARN_ON_ONCE(!class->lock_entry.next);
>   	WARN_ON_ONCE(!list_empty(&class->locks_after));
>   	WARN_ON_ONCE(!list_empty(&class->locks_before));
> -	memset(p + offset, 0, sizeof(*class) - offset);
> +	memset_startat(class, 0, key);
>   	WARN_ON_ONCE(!class->lock_entry.next);
>   	WARN_ON_ONCE(!list_empty(&class->locks_after));
>   	WARN_ON_ONCE(!list_empty(&class->locks_before));

LGTM

Acked-by: Waiman Long <longman@redhat.com>