Date:   Mon, 13 Dec 2021 19:49:06 +0100
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Alistair Francis <alistair23@gmail.com>,
        Alistair Francis <alistair@alistair23.me>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux-input <linux-input@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mylene Josserand <mylene.josserand@free-electrons.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Henrik Rydberg <rydberg@bitmath.org>,
        Rob Herring <robh+dt@kernel.org>,
        =?UTF-8?B?TXlsw6huZQ==?= Josserand <mylene.josserand@bootlin.com>,
        Maxime Ripard <maxime.ripard@bootlin.com>
Subject: Re: [PATCH v2 1/4] Input: Add driver for Cypress Generation 5
 touchscreen
Message-ID: <20211213194906.00fd028c@aktux>
In-Reply-To: <YbbeDFJERtP0mAIQ@google.com>
References: <20211103114830.62711-1-alistair@alistair23.me>
        <20211103114830.62711-2-alistair@alistair23.me>
        <YYYk/uisKqPNgRu0@google.com>
        <CAKmqyKOFZOLpjMY+kj2CLibFhYJ3-tL+9+cKEVzgSn9Mzq30gw@mail.gmail.com>
        <YbbeDFJERtP0mAIQ@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On Sun, 12 Dec 2021 21:45:48 -0800
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:


> > > > +     rc = devm_request_threaded_irq(dev, irq, NULL, cyttsp5_handle_irq,
> > > > +                                    IRQF_TRIGGER_FALLING | IRQF_ONESHOT,  
> > >
> > > Please do not override platform setup with hardcoded triggers. Also, it
> > > is strongly recommended to use level interrupts for these peripherals.
> > >
> > > This is also likely unsafe if controller is not completely shut off and
> > > is capable of generating interrupts given input device is not yet
> > > allocated.  
> > 
> > I have dropped the `IRQF_TRIGGER_FALLING |`
> > 
> > I have tried to use level interrupts, but I can't get the device
> > working with them.  
> 
> That is weird, does the interrupt controller support level interrupts?
> 
hmm, it should, at least on the imx6 I am using them for some other
devices, I guess, on the imx7 they should work, too.
I hope I find time to give that a try the next days.

Regards,
Andreas