MIME-Version: 1.0
References: <1638864419-17501-1-git-send-email-wellslutw@gmail.com>
 <1638864419-17501-2-git-send-email-wellslutw@gmail.com> <YbPHxVf1vXZj9GOC@robh.at.kernel.org>
 <CAFnkrsmXu9ceSQ7rzOAFy_kP6JMa7GvY7HCbT=_wfskH6wXuSw@mail.gmail.com>
In-Reply-To: <CAFnkrsmXu9ceSQ7rzOAFy_kP6JMa7GvY7HCbT=_wfskH6wXuSw@mail.gmail.com>
From:   Rob Herring <robh@kernel.org>
Date:   Mon, 13 Dec 2021 13:30:36 -0600
Message-ID: <CAL_Jsq+5nM2L=p13CSq8FRZX0sMykbXdyBatDR7McUXkv5NXzA@mail.gmail.com>
Subject: Re: [PATCH net-next v4 1/2] devicetree: bindings: net: Add bindings
 doc for Sunplus SP7021.
To:     =?UTF-8?B?5ZGC6Iqz6aiw?= <wellslutw@gmail.com>
Cc:     David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        netdev <netdev@vger.kernel.org>, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Wells Lu <wells.lu@sunplus.com>,
        Vincent Shih <vincent.shih@sunplus.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Dec 11, 2021 at 1:35 PM =E5=91=82=E8=8A=B3=E9=A8=B0 <wellslutw@gmai=
l.com> wrote:
>
> Hi Rob,
>
> Thank you very much for your review.
> Please see my replies below:
>
> > Add bindings documentation for Sunplus SP7021.
> >
> [...]
> > > +
> > > +  interrupts:
> > > +    description: |
> > > +      Contains number and type of interrupt. Number should be 66.
> >
> > Drop. That's every 'interrupts' and the exact number is outside the
> > scope of the binding.
>
> Yes, I'll drop the descriptions next patch.
> interrupts property will be:
>
>   interrupts:
>     maxItems: 1
>
>
> [...]
> > > +
> > > +  mdio:
> >
> > Just need:
> >
> >        $ref: mdio.yaml#
> >        unevaluatedProperties: false
> >
> > and drop the rest.
>
> Yes, I'll modify mdio node next patch.
> mdio node will be:
>
>   mdio:
>     $ref: mdio.yaml#
>     unevaluatedProperties: false
>
>
> > > +    type: object
> > > +    description: external MDIO Bus
> > > +
> > > +    properties:
> > > +      "#address-cells":
> > > +        const: 1
> > > +
> > > +      "#size-cells":
> > > +        const: 0
> > > +
> > > +    patternProperties:
> > > +      "^ethernet-phy@[0-9a-f]+$":
> > > +        type: object
> > > +        description: external PHY node
> > > +
> > > +        properties:
> > > +          reg:
> > > +            minimum: 0
> > > +            maximum: 30
>
> Can I limit value of 'reg' to no more than 30?

Isn't that the limit for any MDIO bus? I guess normally 31 is also
valid? I'm not really sure it is worth adding just for that 1 possible
value. Within the range of valid addresses, we can't ever validate
that a DT has the correct address.

Rob