Subject: Re: [PATCH v4 0/6] staging: media: wave5: add wave5 codec driver
To:     Daniel Palmer <daniel@0x0f.com>
Cc:     "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" 
        <linux-media@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
        open list <linux-kernel@vger.kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com,
        Robert Beckett <bob.beckett@collabora.com>,
        kiril.bicevski@collabora.com,
        Nas Chung <nas.chung@chipsnmedia.com>,
        lafley.kim@chipsnmedia.com, scott.woo@chipsnmedia.com,
        olivier.crete@collabora.com, dan.carpenter@oracle.com,
        Randy Dunlap <rdunlap@infradead.org>
References: <20211201175613.13710-1-dafna.hirschfeld@collabora.com>
 <CAFr9PXnvbqtx-SpxjyO2uvoBR3ueNBD9vSFnbqjbAHz_7Lh8VA@mail.gmail.com>
From:   Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Message-ID: <02a9c780-49e0-7a61-4443-7825d6a1271e@collabora.com>
Date:   Mon, 13 Dec 2021 22:27:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAFr9PXnvbqtx-SpxjyO2uvoBR3ueNBD9vSFnbqjbAHz_7Lh8VA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 02.12.21 12:11, Daniel Palmer wrote:
> Hi Dafna,
> 
> On Thu, 2 Dec 2021 at 02:56, Dafna Hirschfeld
> <dafna.hirschfeld@collabora.com> wrote:
>> Testing on BeagleV shows buffer corruption that is currently attributed to a
>> known silicon issue in the SoC that makes the cache coherent interconnect not
>> so coherent.
> 
> Maybe it's mentioned somewhere else and I missed it but would it be
> possible to tell me which version of the IP is in the BeagleV chip?
> The reason I ask is I'm trying to get this going on the SigmaStar
> SSD202D which seems to have the "Wave 511".
> I can see the firmware binary get uploaded and it seems to do
> something as the register that exposes the vcpu program counter is
> doing something (and the addresses look the same as the addresses seem
> when the working vendor kernel + binary .ko are running so I think
> it's not just running garbage).
> 
> I'm wondering if the BeagleV is a different version and the driver
> just won't work as is on mine or maybe the firmware I have has hacks
> for the vendors version of the driver which I don't have source for.

Hi, thank you for trying this out. The versions I see on the Beaglv are 511 for the
decoder and 521c for the encoder.
This driver is also based on a vendor driver from cnm: https://gitlab.collabora.com/chipsnmedia/wave5-driver
Also, a patch to add the firmware was also sent to linux-firmware ml https://lore.kernel.org/linux-firmware/20211126093014.1385752-1-nas.chung@chipsnmedia.com/T/

Thanks,
Dafna

> 
> Thanks,
> 
> Daniel
>